From 3ce9346ad1f3306cab3f39abcc14a21f2ac1f642 Mon Sep 17 00:00:00 2001
From: Shailesh Vashishth <shailesh.vashishth@juspay.in>
Date: Thu, 17 Oct 2024 14:41:19 +0530
Subject: [PATCH 01/15] changed the math expression in store_client.cc file
 from (a/b/c > d) to (a > b*d/c)

---
 src/store_client.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/store_client.cc b/src/store_client.cc
index 6288b0dcbf8..9cc2e143822 100644
--- a/src/store_client.cc
+++ b/src/store_client.cc
@@ -990,7 +990,7 @@ CheckQuickAbortIsReasonable(StoreEntry * entry)
         return false;
     }
 
-    if ((curlen / (expectlen / 100)) > (Config.quickAbort.pct)) {
+    if (curlen > expectlen*(Config.quickAbort.pct/100.0)) {
         debugs(90, 3, "quick-abort? NO past point of no return");
         return false;
     }

From b06616d0101457c61fd0d3a065f1193bb8dccc24 Mon Sep 17 00:00:00 2001
From: Shailesh Vashishth <22538656+vshailesh@users.noreply.github.com>
Date: Thu, 24 Oct 2024 10:39:54 +0530
Subject: [PATCH 02/15] removed division by zero check condition in
 store_client.cc

---
 src/store_client.cc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/store_client.cc b/src/store_client.cc
index 9cc2e143822..12b730fc4fc 100644
--- a/src/store_client.cc
+++ b/src/store_client.cc
@@ -984,12 +984,6 @@ CheckQuickAbortIsReasonable(StoreEntry * entry)
         return true;
     }
 
-    // XXX: This is absurd! TODO: For positives, "a/(b/c) > d" is "a*c > b*d".
-    if (expectlen < 100) {
-        debugs(90, 3, "quick-abort? NO avoid FPE");
-        return false;
-    }
-
     if (curlen > expectlen*(Config.quickAbort.pct/100.0)) {
         debugs(90, 3, "quick-abort? NO past point of no return");
         return false;

From 52395964669f93b2ff23188d5490e5d225081126 Mon Sep 17 00:00:00 2001
From: Shailesh Vashishth <22538656+vshailesh@users.noreply.github.com>
Date: Thu, 24 Oct 2024 10:44:28 +0530
Subject: [PATCH 03/15] Added to Contributors

---
 CONTRIBUTORS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 26a754f17df..6466ed8c6cc 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,6 +470,7 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
+    Shailesh Vashishth <22538656+vshailesh@users.noreply.github.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>
     Silamael <Silamael@coronamundi.de>
@@ -555,4 +556,4 @@ Thank you!
     Yuhua Wu <ywu@bitglass.com>
     Yuriy M. Kaminskiy <yumkam@gmail.com>
     Zachary Lee Andrews <zcrayfish@gmail.com>
-    Zhanpeng Chen <lowstz@gmail.com>
+    Zhanpeng Chen <lowstz@gmail.com>
\ No newline at end of file

From 14702daf7992c29e1c5c6ca0cebaa7af67c8bea1 Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 25 Oct 2024 09:41:55 -0400
Subject: [PATCH 04/15] fixup: Undo unwanted out-of-scope formatting change

---
 CONTRIBUTORS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 6466ed8c6cc..8c28da61bda 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -556,4 +556,4 @@ Thank you!
     Yuhua Wu <ywu@bitglass.com>
     Yuriy M. Kaminskiy <yumkam@gmail.com>
     Zachary Lee Andrews <zcrayfish@gmail.com>
-    Zhanpeng Chen <lowstz@gmail.com>
\ No newline at end of file
+    Zhanpeng Chen <lowstz@gmail.com>

From 78e14486a86eb6adce389775426d302c1dcdbe1b Mon Sep 17 00:00:00 2001
From: Shailesh Vashishth <22538656+vshailesh@users.noreply.github.com>
Date: Fri, 22 Nov 2024 00:21:26 +0530
Subject: [PATCH 05/15] Updated quick_abort directive documentation and release
 notes

---
 CONTRIBUTORS                        |  2 +-
 doc/release-notes/release-7.sgml.in | 14 ++++++++++++++
 src/cf.data.pre                     |  7 -------
 3 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 8c28da61bda..4066309b871 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,7 +470,7 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
-    Shailesh Vashishth <22538656+vshailesh@users.noreply.github.com>
+    Shailesh Vashishth <shavashishth@gmail.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>
     Silamael <Silamael@coronamundi.de>
diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in
index f33c9992d67..18b4b58af3d 100644
--- a/doc/release-notes/release-7.sgml.in
+++ b/doc/release-notes/release-7.sgml.in
@@ -305,6 +305,20 @@ This section gives an account of those changes in three categories:
 		changed to be in line with Squid's cache.log format.
 </descrip>
 
+<sect1> <label id="modifiedoptions">
+<p>
+<descrip>
+	<tag> Updated precision of quick_abort_pct directive</tag>
+	<p> The <em>quick_abort_pct<em> used to keep the connection open with the 
+	server if the total size of data (header_size + content_length) was smaller
+	than 100 bytes. Now Squid would honour the quick_abort_pct directive for 
+	data of all sizes. 
+	Additionally quick_abort_* directive's documentation incorrectly states that
+	Squid would continue downloading the data if the size of data is less than 
+	16 KB. In reality squid closes connection if niether of the three quick_abort 
+	directive prevent it from doing so.
+<descrip>
+
 <sect>Copyright
 <p>
 Copyright (C) 1996-2023 The Squid Software Foundation and contributors
diff --git a/src/cf.data.pre b/src/cf.data.pre
index 1c0d2583738..69d300dcd36 100644
--- a/src/cf.data.pre
+++ b/src/cf.data.pre
@@ -6626,13 +6626,6 @@ TYPE: int
 DEFAULT: 95
 LOC: Config.quickAbort.pct
 DOC_START
-	The cache by default continues downloading aborted requests
-	which are almost completed (less than 16 KB remaining). This
-	may be undesirable on slow (e.g. SLIP) links and/or very busy
-	caches.  Impatient users may tie up file descriptors and
-	bandwidth by repeatedly requesting and immediately aborting
-	downloads.
-
 	When the user aborts a request, Squid will check the
 	quick_abort values to the amount of data transferred until
 	then.

From d7b673966c7c80252a4a15b89b580ff8922652ac Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 21 Nov 2024 18:04:52 -0500
Subject: [PATCH 06/15] fixup: Polished quick_abort_pct docs

---
 src/cf.data.pre | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/cf.data.pre b/src/cf.data.pre
index 69d300dcd36..abd3e6edfb7 100644
--- a/src/cf.data.pre
+++ b/src/cf.data.pre
@@ -6626,9 +6626,14 @@ TYPE: int
 DEFAULT: 95
 LOC: Config.quickAbort.pct
 DOC_START
-	When the user aborts a request, Squid will check the
-	quick_abort values to the amount of data transferred until
-	then.
+	Continuing to download a cachable response after its request is aborted is
+	going to waste resources if the received response is not requested again.
+	On the other hand, aborting an in-progress download may effectively waste
+	(already spent) resources if the received cachable response is requested
+	again. Such waste is especially noticeable when, for example, impatient
+	users repeatedly request and then abort slow downloads. To balance these
+	trade-offs when a request is aborted during response download, Squid may
+	check quick_abort_* directives to decide whether to finish the retrieval:
 
 	If the transfer has less than 'quick_abort_min' KB remaining,
 	it will finish the retrieval.
@@ -6645,6 +6650,10 @@ DOC_START
 
 	If you want retrievals to always continue if they are being
 	cached set 'quick_abort_min' to '-1 KB'.
+
+	Many other conditions affect Squid decision to abort or continue download.
+	For example, Squid continues to download responses that feed other
+	requests but aborts responses with unknown body length.
 DOC_END
 
 NAME: read_ahead_gap

From 018af44c69a790748efa110645509cfc93fede43 Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 21 Nov 2024 18:12:55 -0500
Subject: [PATCH 07/15] fixup: Polished quick_abort_pct directive notes

---
 doc/release-notes/release-7.sgml.in | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in
index 18b4b58af3d..de3a6a9b3e8 100644
--- a/doc/release-notes/release-7.sgml.in
+++ b/doc/release-notes/release-7.sgml.in
@@ -308,15 +308,19 @@ This section gives an account of those changes in three categories:
 <sect1> <label id="modifiedoptions">
 <p>
 <descrip>
-	<tag> Updated precision of quick_abort_pct directive</tag>
-	<p> The <em>quick_abort_pct<em> used to keep the connection open with the 
-	server if the total size of data (header_size + content_length) was smaller
-	than 100 bytes. Now Squid would honour the quick_abort_pct directive for 
-	data of all sizes. 
-	Additionally quick_abort_* directive's documentation incorrectly states that
-	Squid would continue downloading the data if the size of data is less than 
-	16 KB. In reality squid closes connection if niether of the three quick_abort 
-	directive prevent it from doing so.
+	<tag>quick_abort_pct</tag>
+	<p>Instead of ignoring <em>quick_abort_pct</em> settings that would,
+	   together with other conditions, abort a pending download of a 99-byte or
+	   smaller response, Squid now honors <em>quick_abort_pct</em> for all
+	   response sizes. Most Squids are not going to be affected by this change
+	   because default quick_abort_min settings (16KB) prevent aborts of
+	   99-byte responses even before <em>quick_abort_pct</em> is checked.
+	<p>Due to conversion from integer to floating point math, this change may
+	   affect responses larger than 99 bytes as well, but these effects ought
+	   to be limited to cases where the decision is based on a tiny difference
+	   (e.g., receiving 1% more bytes would have triggered full download). In
+	   most such cases, the decision could probably go either way due to
+	   response header size fluctuations anyway.
 <descrip>
 
 <sect>Copyright

From 71023c6154eeb217a97b492dfe159e57b38298a0 Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 21 Nov 2024 18:13:57 -0500
Subject: [PATCH 08/15] fixup: Fixed XML

---
 doc/release-notes/release-7.sgml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in
index de3a6a9b3e8..9f9436a847e 100644
--- a/doc/release-notes/release-7.sgml.in
+++ b/doc/release-notes/release-7.sgml.in
@@ -321,7 +321,7 @@ This section gives an account of those changes in three categories:
 	   (e.g., receiving 1% more bytes would have triggered full download). In
 	   most such cases, the decision could probably go either way due to
 	   response header size fluctuations anyway.
-<descrip>
+</descrip>
 
 <sect>Copyright
 <p>

From cd6044b4f9659a962f49adf9aae4e6965644a34b Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 21 Nov 2024 18:16:23 -0500
Subject: [PATCH 09/15] fixup: Fixed quick_abort_pct note location

---
 doc/release-notes/release-7.sgml.in | 31 ++++++++++++-----------------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in
index 9f9436a847e..74953ade9fe 100644
--- a/doc/release-notes/release-7.sgml.in
+++ b/doc/release-notes/release-7.sgml.in
@@ -194,6 +194,19 @@ This section gives an account of those changes in three categories:
 	<tag>external_acl_type</tag>
 	<p>Removed <em>%IDENT</em> format code with Ident protocol support.
 
+	<tag>quick_abort_pct</tag>
+	<p>Instead of ignoring <em>quick_abort_pct</em> settings that would,
+	together with other conditions, abort a pending download of a 99-byte or
+	smaller response, Squid now honors <em>quick_abort_pct</em> for all
+	response sizes. Most Squids are not going to be affected by this change
+	because default quick_abort_min settings (16KB) prevent aborts of 99-byte
+	responses even before <em>quick_abort_pct</em> is checked.
+	<p>Due to conversion from integer to floating point math, this change may
+	affect responses larger than 99 bytes as well, but these effects ought to
+	be limited to cases where the decision is based on a tiny difference (e.g.,
+	receiving 1% more bytes would have triggered full download). In most such
+	cases, the decision could probably go either way due to response header
+	size fluctuations anyway.
 </descrip>
 
 <sect1>Removed directives<label id="removeddirectives">
@@ -305,24 +318,6 @@ This section gives an account of those changes in three categories:
 		changed to be in line with Squid's cache.log format.
 </descrip>
 
-<sect1> <label id="modifiedoptions">
-<p>
-<descrip>
-	<tag>quick_abort_pct</tag>
-	<p>Instead of ignoring <em>quick_abort_pct</em> settings that would,
-	   together with other conditions, abort a pending download of a 99-byte or
-	   smaller response, Squid now honors <em>quick_abort_pct</em> for all
-	   response sizes. Most Squids are not going to be affected by this change
-	   because default quick_abort_min settings (16KB) prevent aborts of
-	   99-byte responses even before <em>quick_abort_pct</em> is checked.
-	<p>Due to conversion from integer to floating point math, this change may
-	   affect responses larger than 99 bytes as well, but these effects ought
-	   to be limited to cases where the decision is based on a tiny difference
-	   (e.g., receiving 1% more bytes would have triggered full download). In
-	   most such cases, the decision could probably go either way due to
-	   response header size fluctuations anyway.
-</descrip>
-
 <sect>Copyright
 <p>
 Copyright (C) 1996-2023 The Squid Software Foundation and contributors

From fb14e2756acf40e909817a9fc82cb0ec66d25e5d Mon Sep 17 00:00:00 2001
From: Shailesh Vashishth <shailesh.vashishth@juspay.in>
Date: Fri, 22 Nov 2024 14:08:31 +0530
Subject: [PATCH 10/15] Updated Contributors

---
 CONTRIBUTORS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 4066309b871..e8c97a963cb 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,6 +470,7 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
+    Shailesh <22538656+vshailesh@users.noreply.github.com>
     Shailesh Vashishth <shavashishth@gmail.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>

From 84be2f1cd1d6f5bd87aa6be578674788a3d1f32c Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 22 Nov 2024 08:38:41 -0500
Subject: [PATCH 11/15] fixup: Removed one of the two emails after updating PR
 description

---
 CONTRIBUTORS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index e8c97a963cb..4066309b871 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,7 +470,6 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
-    Shailesh <22538656+vshailesh@users.noreply.github.com>
     Shailesh Vashishth <shavashishth@gmail.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>

From 5cd43e1fa9fc50babf9361bcc4bcbc2987ff99b2 Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 22 Nov 2024 08:59:47 -0500
Subject: [PATCH 12/15] fixup: Restored empty line

---
 doc/release-notes/release-7.sgml.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/release-notes/release-7.sgml.in b/doc/release-notes/release-7.sgml.in
index 74953ade9fe..47039e78271 100644
--- a/doc/release-notes/release-7.sgml.in
+++ b/doc/release-notes/release-7.sgml.in
@@ -207,6 +207,7 @@ This section gives an account of those changes in three categories:
 	receiving 1% more bytes would have triggered full download). In most such
 	cases, the decision could probably go either way due to response header
 	size fluctuations anyway.
+
 </descrip>
 
 <sect1>Removed directives<label id="removeddirectives">

From e1723b6aa616dc76e5ddfa1c8303486cf803103b Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 22 Nov 2024 09:45:41 -0500
Subject: [PATCH 13/15] fixup: Undo CONTRIBUTORS changes to redo them with
 magic

... phrase in the next commit.
---
 CONTRIBUTORS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 4066309b871..26a754f17df 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,7 +470,6 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
-    Shailesh Vashishth <shavashishth@gmail.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>
     Silamael <Silamael@coronamundi.de>

From 042cd963c563616852124cdf3eeedebc513c84c8 Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 22 Nov 2024 11:46:20 -0500
Subject: [PATCH 14/15] fixup: Re-add the right author to CONTRIBUTORS (with
 magic)

This change is a reference point for automated CONTRIBUTORS updates.
---
 CONTRIBUTORS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index 26a754f17df..4066309b871 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -470,6 +470,7 @@ Thank you!
     Sergey Merzlikin <sm@smsoft.ru>
     Sergio Durigan Junior <sergiodj@sergiodj.net>
     Sergio Rabellino <rabellino@di.unito.it>
+    Shailesh Vashishth <shavashishth@gmail.com>
     Shigechika Aikawa <shige@luck.imasy.or.jp>
     Shmaya Frankel <shmaya.frankel@gmail.com>
     Silamael <Silamael@coronamundi.de>

From bcd15b83bc248d52e592648980455cf530e91b2e Mon Sep 17 00:00:00 2001
From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sat, 23 Nov 2024 08:39:05 -0500
Subject: [PATCH 15/15] fixup: Empty commit to change GitHub merge commit

... in hope to get updated author info into that
merge commit.