Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client to include aliases in enrollment request #40

Open
bensallen opened this issue Aug 2, 2016 · 5 comments
Open

Allow client to include aliases in enrollment request #40

bensallen opened this issue Aug 2, 2016 · 5 comments

Comments

@bensallen
Copy link
Contributor

Allow the client to include multiple alias hostnames in its enrollment request, where the additional hostnames are added as aliases in known_hosts output. This will be useful for multi-homed clients. The aliases should be validated against the client SSL cert.

@mcpherrinm
Copy link
Contributor

👍

@christodenny
Copy link
Collaborator

What's recommended?
Should different aliases all be submitted in the url or in a header tag?

@bensallen
Copy link
Contributor Author

@christodenny The body could be changed to JSON and the client's pub key and aliases marshaled. Otherwise I'd say a header tag sounds cleaner than using the URL.

@mcpherrinm
Copy link
Contributor

I would tend to prefer just putting them in the URL, but headers or JSON could be fine too.

If I have a spare moment, I might get to this task this week or the next.

We're going to add a server-side configuration too, where a hardcoded mapping of hosts => aliases can be added (we have a small-ish number of ones that aren't on TLS certs, so that's the easiest bodge for us)

@bensallen
Copy link
Contributor Author

For passing aliases via the URL, do you imagine that we'd join the list of aliases on a given separator? Then pass the joined list as a single variable in the URL, or is there a more clever way todo this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants