Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inadequate keep rules with R8 full mode version 3.0 #3580

Closed
christofferqa opened this issue Jun 24, 2021 · 0 comments · Fixed by #3579
Closed

Inadequate keep rules with R8 full mode version 3.0 #3580

christofferqa opened this issue Jun 24, 2021 · 0 comments · Fixed by #3579

Comments

@christofferqa
Copy link
Contributor

R8 version 3.0 started to remove generic signatures from items that are not matched by a -keep rule in full mode (see also https://r8.googlesource.com/r8/+/744d742137a82656b8ee27513f975e0528aecd78). The motivation for this change is to avoid that all generic signatures are retained in programs, when only a few are typically required for reflection.

As a result of this change, an extra -keep rule for retrofit2.Call is required to keep its generic signature.

I have opened PR #3579 to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant