Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a "generate Dagger factories only" mode #164

Closed
vRallev opened this issue Nov 30, 2020 · 3 comments
Closed

Have a "generate Dagger factories only" mode #164

vRallev opened this issue Nov 30, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@vRallev
Copy link
Collaborator

vRallev commented Nov 30, 2020

One downside of Anvil is that it disables incremental compilation for the stub generating task. For some projects that could be a performance killer. At the same time, these projects would be interested in using the feature to generate Dagger factories. For that we don't need to disable incremental compilation.

@vRallev vRallev added the enhancement New feature or request label Nov 30, 2020
@ursusursus
Copy link

So, this is for the case where I want anvil to replace dagger kapt for compiling a @Module; but I don't have @ContributesTo on it?

@vRallev
Copy link
Collaborator Author

vRallev commented Jan 6, 2021

I'd suggest to use this mode ONLY in projects that never use @ContributesTo, but want to use Anvil for compiling @Modules to remove Kapt. I wouldn't switch this flag on and off for separate modules, the benefit wouldn't be worth the extra effort.

@ursusursus
Copy link

I see, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants