Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pointless warning #75

Merged
merged 1 commit into from
Mar 13, 2023
Merged

remove pointless warning #75

merged 1 commit into from
Mar 13, 2023

Conversation

araujoms
Copy link
Contributor

@araujoms araujoms commented Mar 1, 2023

It doesn't make sense to use struct('issym',true)) here as XX is just a numerical matrix. It was causing pointless warnings.

It doesn't make sense to use `struct('issym',true))` here as `XX` is just a numerical matrix. It was causing pointless warnings.
@siko1056
Copy link
Member

siko1056 commented Mar 12, 2023

In line 92 before that code I see

XX = XX + XX';

Doesn't this make the input of eigs a symmetric matrix? What is the warning seen in Matlab and what is the warning exactly?

@araujoms
Copy link
Contributor Author

Yes, XX is symmetric, but that's not the issue. The warning I get from MATLAB is "Warning: Ignoring issym field in the options structure since the first input is not a function handle." It's because this option only applies when XX is not a numerical matrix, but a function handle. See the documentation. And in SeDuMi's code XX is always just a numerical matrix as far as I can see.

@siko1056 siko1056 mentioned this pull request Mar 13, 2023
@siko1056 siko1056 merged commit 5574f42 into sqlp:master Mar 13, 2023
@araujoms araujoms deleted the patch-1 branch March 15, 2023 08:36
@siko1056
Copy link
Member

Oh my comment was not posted 😓 Many thanks for the clarification, I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants