Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with Coverage 6.3 #2483

Closed
tunetheweb opened this issue Jan 25, 2022 · 8 comments · Fixed by #3393
Closed

Possible issue with Coverage 6.3 #2483

tunetheweb opened this issue Jan 25, 2022 · 8 comments · Fixed by #3393
Labels
bug Something isn't working test cases Where we could improve test cases

Comments

@tunetheweb
Copy link
Member

Expected Behaviour

CI should run and be reasonably stable

Observed Behaviour

CI has been very unstable this evening, particularly for python 3.7. Looks like coverage 6.3 was released with some changes here, and did see some coverage error messages. I frooze it at 6.2 in #2479 and CI completed first time, despite not working one any open PRs for ages.

Steps to Reproduce

Unfreeze coverage in requirements_dev.txt and run tests on Python 3.7. I can't get that set up on my local machine to confirm, but seems to be the case in CI.

Dialect

All

Version

0.9.2

Configuration

Default

@tunetheweb tunetheweb added the bug Something isn't working label Jan 25, 2022
@tunetheweb
Copy link
Member Author

I raised this: nedbat/coveragepy#1310

We'll stay on 6.2 and see if more stable.

If anyone has any idea how to get a minimal repo to give to them then let me know!

@tunetheweb tunetheweb added the test cases Where we could improve test cases label Jan 26, 2022
@barrywhart
Copy link
Member

I looked at the linked issue in the coveragepy repo, and there's active discussion on it. It sounds like they've seen similar issues elsewhere. 🤞

@tunetheweb
Copy link
Member Author

Yup I'm keeping an eye on it, and tested one branch for them (but didn't fix it). Will leave this issue open to remind us to unpin it, if it gets resolved (at which point we might want to set minimum version number - pity you can't say != 6.3, but don't think you can do that).

@barrywhart
Copy link
Member

Actually, you can specify !=. https://www.python.org/dev/peps/pep-0440/#version-exclusion

The link provides an example and explanation.

@tunetheweb
Copy link
Member Author

Oh nice!

@tunetheweb tunetheweb mentioned this issue Feb 3, 2022
1 task
@barrywhart
Copy link
Member

I see that coverage 6.3.1 was released a couple months ago, and it says it fixed some of the deadlocks they were seeing. Do we know if that version fixes our issues?

https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst#version-631--2022-02-01

@tunetheweb
Copy link
Member Author

Nope. Hence why nedbat/coveragepy#1310 is still open.

@tunetheweb
Copy link
Member Author

Fixed in coverage 6.4: nedbat/coveragepy#1310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test cases Where we could improve test cases
Projects
None yet
2 participants