Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selective disabling of rules per query #3620

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Allow selective disabling of rules per query #3620

wants to merge 7 commits into from
+219 −75

Commits on Nov 25, 2024

  1. Extended the @sqlc-vet-disable flag to support the skipping of prov… 

    …ided rules.

This is an update to the original behaviour which had an "all-or-nothing" behaviour, either running all the rules on a query or skipping them all.
Specified rules which aren't declared in the sqlc config file get rejected.
    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d8a8110 View commit details
    Browse the repository at this point in the history

  2. Updated tests to cover new vet disabling behaviour.

    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    28e7e4b View commit details
    Browse the repository at this point in the history

  3. Relocated constants for query flags to a dedicated package to allow f… 

    …or safer reuse.
    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5c1546d View commit details
    Browse the repository at this point in the history

  4. Renamed the metadata ParseParamsAndFlags() function to `ParseCommen… 

    …tFlags()` in order to be more generic as it now returns the rule skip list and could potentially return more data in the future.
    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5b81b1c View commit details
    Browse the repository at this point in the history

  5. Updated docs to reflect the support of rule names for the vet disable… 

    … annotation.
    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bef3dba View commit details
    Browse the repository at this point in the history

  6. Slight term change in vet docs.

    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a82fcb4 View commit details
    Browse the repository at this point in the history

  7. Renamed test function for query rule skiplist.

    @rhodeon @kyleconroy
    rhodeon authored and kyleconroy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    474ee13 View commit details
    Browse the repository at this point in the history