Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compareType by default #1248

Closed
CaselIT opened this issue May 24, 2023 · 5 comments
Closed

Enable compareType by default #1248

CaselIT opened this issue May 24, 2023 · 5 comments

Comments

@CaselIT
Copy link
Member

CaselIT commented May 24, 2023

Change the compareType default from False to True

@sqla-tester
Copy link
Collaborator

Federico Caselli has proposed a fix for this issue in the main branch:

Enable compare type by default https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4822

@zzzeek
Copy link
Member

zzzeek commented Aug 13, 2023

what's the background on this? I know the general idea is that at some point we redid type comparison to be a lot better. but are people looking for this? Why open ourselves up to a bunch of new issues that might be very difficult to solve?

@CaselIT
Copy link
Member Author

CaselIT commented Aug 13, 2023

iirc we talked a bit about this on an dev meeting.

shall we introduce a "warn" flag that's the new default, that's basically like true but only log that there are type changes, without then writing them to the migration?

@zzzeek
Copy link
Member

zzzeek commented Aug 13, 2023

nah, let's make the change. we already broke the type comparison hook silently. let's just document all this pretty prominently

@CaselIT
Copy link
Member Author

CaselIT commented Aug 13, 2023

ok, I'll expand the documentation a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants