-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compareType by default #1248
Comments
Federico Caselli has proposed a fix for this issue in the main branch: Enable compare type by default https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4822 |
what's the background on this? I know the general idea is that at some point we redid type comparison to be a lot better. but are people looking for this? Why open ourselves up to a bunch of new issues that might be very difficult to solve? |
iirc we talked a bit about this on an dev meeting. shall we introduce a "warn" flag that's the new default, that's basically like true but only log that there are type changes, without then writing them to the migration? |
nah, let's make the change. we already broke the type comparison hook silently. let's just document all this pretty prominently |
ok, I'll expand the documentation a bit. |
Change the compareType default from False to True
The text was updated successfully, but these errors were encountered: