return in finally swallows exceptions

[iritkatriel]

Issue Report Checklist

• [ x] Searched the issues page for similar reports
• Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
• Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
• Could not reproduce inside jupyter qtconsole (if console-related)
• Tried basic troubleshooting (if a bug/error)
  • Restarted Spyder
  • Reset preferences with spyder --reset
  • Reinstalled the latest version of Anaconda
  • Tried the other applicable steps from the Troubleshooting Guide
• [x ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description

In

spyder/spyder/plugins/explorer/widgets/explorer.py

Line 1322 in 5f4c5cd

return dirname

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhanded exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

What steps reproduce the problem?

Inspect source code.

What is the expected output? What do you see instead?

Avoid return in finally.

Versions

master branch