Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with jpackage and Java9+ #16

Open
Searen1984 opened this issue May 31, 2021 · 2 comments
Open

Incompatible with jpackage and Java9+ #16

Searen1984 opened this issue May 31, 2021 · 2 comments

Comments

@Searen1984
Copy link

Hello,

this project hasn't been updated a long time but still most of it works. However, I found a problem using it as a dependency for a JavaFX program which I package with the Java tool jpackage. The good news is I could solve the problem and will present the solution below. The bad news is I would like to ask you if you could please update xar with the solution? It is probably just updating one line of code. So here is my problem. I get the following error when packaging for MacOS:
Bundler Mac PKG Package skipped because of a configuration problem: java.lang.module.FindException: Unable to derive module descriptor for /[...]/target/libs/joou-java-6-0.9.4.jar

Origin: xar uses as a dependency joou-java-6 (please check here https://github.com/sprylab/xar/blob/master/xar/pom.xml). This dependency is only meant up to Java 8. I am not sure about the exact problem but it is something in connection with the Java modules.

Solution: For Java 9 and later there is the dependency joou with the same version (please check here https://github.com/jOOQ/jOOU). So replacing the artifact id "joou-java-6" with "joou" in the xar pom solved the issue for me.

For this project I would propose that you could

  1. create another build which provides xar for Java 9+ like the joou project does or
  2. just update the line in the pom.

For 2. I do not know if that would still work for Java 8.

Best wishes,
Alex

@hameno
Copy link
Member

hameno commented May 31, 2021

We still require compatibility with Java <9 since this is used on Android. We will not be working on this ourselves, but you are free to propose a PR with the necessary changes (separate module)

@Searen1984
Copy link
Author

Searen1984 commented May 31, 2021

I tested the fix with Java 8 and Java 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants