Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spryker/chart causes npm ci to fail #68

Open
JonasSeegers opened this issue Aug 8, 2024 · 1 comment
Open

spryker/chart causes npm ci to fail #68

JonasSeegers opened this issue Aug 8, 2024 · 1 comment

Comments

@JonasSeegers
Copy link

Hi! We've been updating the @spryker/oryx-for-zed npm package. In the docs it says that this requires us to install the spryker/chart module via composer. But if we do, our pipeline fails, because the npm ci command in vendor/spryker/chart/assets/Zed fails with the following error:

npm ERR! Missing: [email protected] from lock file
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]
npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]

To reproduce, just run npm ci in the assets/Zed directory of the spryker/chart repository. I can't create an issue in that repo. That's why I'm opening it here. Seems as if the package.json and package-lock.json are out of sync. If you run npm i first, it works

npm version is 10.7.0
node version is 20.13.1

@jbtcd
Copy link

jbtcd commented Oct 16, 2024

Hey!
I have the same problems with some other packages.

In https://github.com/spryker/gui and https://github.com/spryker/discount I also need a npm i to run npm ci on the main repo.

Currently, as a quickfix I added some install commands to be able to deploy my application with vendor/bin/console frontend:zed:install-dependencies:

npm --prefix vendor/spryker/chart/assets/Zed i
npm --prefix vendor/spryker/gui/assets/Zed i
npm --prefix vendor/spryker/discount/assets/Zed i

But this should not be the solution, are there plans to solve the problem, and if so, by when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants