Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy.**.yml files import do not get resolved #32

Closed
tcfoo opened this issue Jul 14, 2023 · 2 comments
Closed

deploy.**.yml files import do not get resolved #32

tcfoo opened this issue Jul 14, 2023 · 2 comments

Comments

@tcfoo
Copy link
Contributor

tcfoo commented Jul 14, 2023

When using the evaluate command
docker/sdk cli -x evaluator evaluate --checkers=PHP_VERSION_CHECKER
I receive following error:

===================
PHP VERSION CHECKER
===================

+----+--------------------------------------------------------+----------------------------------------+
| #  | Message                                                | Target                                 |
+----+--------------------------------------------------------+----------------------------------------+
| 1  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.acceptance.mariadb.yml |
+----+--------------------------------------------------------+----------------------------------------+
| 2  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.acceptance.yml         |
+----+--------------------------------------------------------+----------------------------------------+
| 3  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.api.mariadb.yml        |
+----+--------------------------------------------------------+----------------------------------------+
| 4  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.api.yml                |
+----+--------------------------------------------------------+----------------------------------------+
| 5  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.functional.mariadb.yml |
+----+--------------------------------------------------------+----------------------------------------+
| 6  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.ci.functional.yml         |
+----+--------------------------------------------------------+----------------------------------------+
| 7  | Image tag path "[image][tag]" not found in deploy file | /data/deploy.dev.yml                   |
+----+--------------------------------------------------------+----------------------------------------+
| 8  | Not all the targets have same PHP versions             | Current php version 8.2.5: php8        |
|    |                                                        | /data/composer.json: php8              |
|    |                                                        | /data/deploy**.yml: -                  |
|    |                                                        | SDK php versions: php7, php8           |
+----+--------------------------------------------------------+----------------------------------------+

after investigating into the issue I figured out that the
src/Checker/PhpVersionChecker/CheckerStrategy/DeployYamlFilesPhpVersionStrategy.php
does not parse any import´s used in the deploy.**.yml files similar to the docs.

@pavelmaksimov25
Copy link
Contributor

Thank you for the investigation. We'll check this case.

@DmytroKlymanSpryker
Copy link
Contributor

The issue has been resolved in the release 0.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants