Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link editing and removal are unreliable #47

Closed
tomdyson opened this issue May 17, 2017 · 4 comments
Closed

Link editing and removal are unreliable #47

tomdyson opened this issue May 17, 2017 · 4 comments
Labels
Milestone

Comments

@tomdyson
Copy link

See screencast. I haven't been able to establish a pattern!

draftail-link-edit

@tomdyson tomdyson changed the title Link editing and removal is unreliable Link editing and removal are unreliable May 17, 2017
@thibaudcolas
Copy link
Contributor

I think I have experienced this too, didn't manage to pinpoint the cause either. Will investigate.

@thibaudcolas thibaudcolas added this to the v1.0.0 milestone May 17, 2017
@jjanssen
Copy link

jjanssen commented May 19, 2017

It seems like the initial cause itself is a part of the prefixing icon and not being able to select the first letter when visible (the w in Toms screen). At that point the cursor will jump to the beginning of the icon which does not hold the link but still shows the dialog.

When you disable the icon this is partially the same behaviour except the 1st letter is now clickable / targetable. But also when the cursor is in front of the first letter, it shows the dialog, but does not respond to either Edit or Remove.

Update: DraftJS Link demo shows the same behaviour with cursor in front of the text.

@loicteixeira
Copy link
Contributor

Regardless of what default is chosen, the configuration should be documented (or linked to the draft one?)

@thibaudcolas
Copy link
Contributor

Moving this to springload/draftail#109, as the issue isn't specific to WagtailDraftail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants