Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Draft.js copy-paste handling overrides from draftjs-conductor. Fix #147 #155

Merged
merged 4 commits into from
Jun 4, 2018

Conversation

thibaudcolas
Copy link
Collaborator

@thibaudcolas thibaudcolas commented Jun 3, 2018

Fixes #147. Adds Draft.js copy-paste handling overrides from draftjs-conductor. This makes Draftail always preserve the full content as-is when copy-pasting between editors. See thibaudcolas/draftjs-conductor#2) and #147 for more info.

Also: Update to [email protected]. This does not include any functional changes, but will cause a duplicated dependency for projects having both draftail and draftjs-filters as deps if they don’t also update draftjs-filters.

@thibaudcolas thibaudcolas added the bug Something isn't working label Jun 3, 2018
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jun 3, 2018
@thi-bot
Copy link
Collaborator

thi-bot commented Jun 3, 2018

Warnings
⚠️

This pull request updates the library. Should the API reference be updated as well? The User guide?

Generated by 🚫 dangerJS

@thibaudcolas
Copy link
Collaborator Author

@thi-bot we're good. The user guide references #138, this will indeed need to be updated as part of the next release. A link to this issue should be added to Danger as well.

@thibaudcolas
Copy link
Collaborator Author

This PR does very little as most of the work was done in thibaudcolas/draftjs-conductor#2, so I'll merge now to facilitate testing via the demo site. We can still change the implementation as required in a separate PR.

@thibaudcolas thibaudcolas merged commit 35dcd13 into master Jun 4, 2018
@thibaudcolas thibaudcolas deleted the feature/copy-paste-override-147 branch June 4, 2018 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants