Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor position is incorrect at the start of an inline entity / decorator with an icon #87

Closed
2 tasks
thibaudcolas opened this issue Jul 24, 2017 · 1 comment
Labels
bug Something isn't working

Comments

@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Jul 24, 2017

This is better explained with a GIF:

draftail-start-cursor

  • If the cursor is right before a decorator with an icon, it is displayed in between the icon and the first letter of the decorator. (text is correctly added before the icon)
  • If the cursor is to the left of a space character placed right before an entity, it is not displayed at all.
@thibaudcolas
Copy link
Collaborator Author

I think this might have been fixed in a recent release because I can't reproduce anymore. That or contenteditable is really unreliable.

Here is the new behavior:

cursor-entity-icon

This is more user-friendly because the text appears where the cursor is. It's still a bit frustrating not to ever have the cursor just before the first letter of the entity (a here), but it still is technically there – it's just that there is a big icon after it.

If this is too distracting, the best way to fix this is to simply remove the icon and-or reduce the padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant