Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log files are public available #11

Open
abma opened this issue Feb 3, 2020 · 3 comments
Open

log files are public available #11

abma opened this issue Feb 3, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@abma
Copy link
Contributor

abma commented Feb 3, 2020

they should be protected somehow, not sure what to use for auth...

@dansan
Copy link
Member

dansan commented Feb 4, 2020

Yeah… until now this service was in testing mode (all open) for lobby developers. If this should go live, auth is a must.

Auth using lobby accounts is no problem (see replay site). I don't know about forum accounts.
The questions are:

  • who to allow access?
  • allow access to all logs or filter by dev→game?

I suggest to start with "all engine and game devs have access to all uploaded logs".

I can code the authentication/authorization part, but I'm not active enough in the dev community, so I'd like to have someone else managing the account operations.

@dansan dansan added the question Further information is requested label Feb 4, 2020
@TurBoss
Copy link

TurBoss commented Feb 4, 2020

I can take care of this

@dansan
Copy link
Member

dansan commented Feb 5, 2020

Great. Then we'll just need to wait for spring/uberserver#365 and @TurBoss having write access to the group_user table.
The code here will be the same as in the replay site (I guess I should make it a standalone "Django app" with its own git repo) plus: after authenticating the user asking the lobby server if the user is in the "infolog_reader" group (or similar).

@abma abma added enhancement New feature or request and removed question Further information is requested labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants