Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAY needs to update lastid #241

Open
abma opened this issue Oct 19, 2017 · 5 comments
Open

SAY needs to update lastid #241

abma opened this issue Oct 19, 2017 · 5 comments
Labels

Comments

@abma
Copy link
Contributor

abma commented Oct 19, 2017

else on rejoin duplicate messages are shown

@abma
Copy link
Contributor Author

abma commented Oct 19, 2017

maybe:
-> JSON {"cmd":"say", "msg": "hello world" ....}
<- JSON {"cmd":"say", "lastid": 3}

@abma
Copy link
Contributor Author

abma commented Oct 19, 2017

i guess this needs a new compat flag?!

@abma
Copy link
Contributor Author

abma commented Oct 19, 2017

or easier:

JSON {"cmd": "login", "username": ...."} sets the flag?!

@abma
Copy link
Contributor Author

abma commented Oct 19, 2017

better:

-> JSON {"cmd": "join", "lastid": 1337 ... }
-> JSON {"cmd": "say" ... }
<- JSON {"cmd": "say", "lastid": 1338, ...}

(json join enables json mode?!)

@silentwings
Copy link
Contributor

n2s, mix of json & non-json SAID is involved here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants