Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support range markers show Computing... when looking for quick fixes #989

Closed
martinlippert opened this issue Mar 7, 2023 · 2 comments
Closed
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: bug

Comments

@martinlippert
Copy link
Member

The support range markers look like they have a quick fix available (the quick fix context-menu item is enabled for them), but trying to show the quick fixes shows them as Computing....

Since there are no quick fixes available for those support range markers, they should be marked as not having quick fixes, so that there is nothing trying to show quick fixes on the UI.

@martinlippert martinlippert added type: bug for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation labels Mar 7, 2023
@martinlippert martinlippert added this to the 4.18.0.RELEASE milestone Mar 7, 2023
@BoykoAlex
Copy link
Contributor

Good catch... I feel like I might have spotted this before but didn't pay enough attention. This looks like a regression on the LSP4E side (refactoring of server executors api). Here is the PR for lsp4e: eclipse-lsp4e/lsp4e#531

@BoykoAlex
Copy link
Contributor

Should be fixed in LSP4E via eclipse-lsp4e/lsp4e#535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: bug
Projects
None yet
Development

No branches or pull requests

2 participants