Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[validation] Parse sources with Rewrite slower than JDT #971

Closed
BoykoAlex opened this issue Feb 9, 2023 · 2 comments
Closed

[validation] Parse sources with Rewrite slower than JDT #971

BoykoAlex opened this issue Feb 9, 2023 · 2 comments
Assignees
@BoykoAlex
Labels
theme: performance theme: validation type: enhancement
Milestone
4.18.0.RELEASE

Comments

@BoykoAlex
Copy link
Contributor

Investigate possible performance improvements in parsing CUs with Rewrite as they seem slower than with JDT.
This is important to reconcile code in the opened editor while user is typing.
@BoykoAlex BoykoAlex added this to the 4.18.0.RELEASE milestone Feb 9, 2023
@BoykoAlex BoykoAlex self-assigned this Feb 9, 2023
@BoykoAlex
Copy link
Contributor Author

STS4 side: ac946ff (RewriteCompilationUnitCache has JavaParser#reset(Collection<URI>) call commented out until PR is merged into Rewrite)
Rewrite commits:
openrewrite/rewrite@45f828b
Rewrite PRs:
openrewrite/rewrite#2789
openrewrite/rewrite#2821

@BoykoAlex
Copy link
Contributor Author

Rewrite PRs merged. Our side integration of changes from Rewrite: 18c4c10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
theme: performance theme: validation type: enhancement
Projects
None yet
Milestone
4.18.0.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex