Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user more information about what is "java sources reconciling" #920

Closed
yennor opened this issue Dec 7, 2022 · 4 comments
Closed

Give user more information about what is "java sources reconciling" #920

yennor opened this issue Dec 7, 2022 · 4 comments
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: documentation type: enhancement

Comments

@yennor
Copy link

yennor commented Dec 7, 2022

Expected Behavior

When asking the user if java sources reconciling should be activated, maybe give a little hint or link to documentation, what it's supposed to do.
Current Behavior

just ask if to enable it or not. Afterwards I was unable to find the setting to deactivate it again.

Context
I've updated Eclipse and the Spring Tools Extension when I was asked if I want to enable "additional Spring java sources reconciling". Without any further explanation. Couldn-t find anything on google about it. But found out that the question was probably its from the Spring Tool extension (if not, close that issue). Tried to find the setting, to enable/disable it to see what difference it makes. But also can't find that setting anywhere.

@BoykoAlex
Copy link
Contributor

Both the setting for the popup dialog and the reconciling are here
Screenshot 2022-12-07 at 18 37 55

Additional info on the Spring Boot specific reconciling for Java is coming in the near future in a form of blog posts and likely youtube videos. We'll think how to make this UI more informative.
This reconciling is mostly about spring annotations in your code, their proper usage, modernizations (RequestMapping -> GetMapping, etc). Some Spring AOT and Boot 3 validations.

@martinlippert martinlippert added type: documentation for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring and removed status: waiting-for-triage labels Dec 9, 2022
@martinlippert
Copy link
Member

The user guide also contains a short section on this: https://github.com/spring-projects/sts4/wiki/Validations-And-Quick-Fixes.

But I agree, we need to put more details out on the UI directly.

@martinlippert martinlippert added this to the 4.17.1.RELEASE milestone Dec 9, 2022
@BoykoAlex
Copy link
Contributor

I'll mark it as fixed with c1accd1
I have add the URL hyper link to the popup in VSCode and Eclipse. I have re-worked Eclipse's popup using JFace Notification such that it looks like the popup in VSCode.

@tommai78101
Copy link

If you're on the latest Eclipse IDE for Java (using Eclipse IDE 2023-03 as an example), and you're using Spring Tool Suite 4 plugin from Eclipse Marketplace, the settings, shown by BoykoAlex, are in a different location:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: documentation type: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants