Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode "Problems" diagnostic entries lack "source" field #725

Closed
shoffmeister opened this issue Feb 2, 2022 · 2 comments
Closed

vscode "Problems" diagnostic entries lack "source" field #725

shoffmeister opened this issue Feb 2, 2022 · 2 comments

Comments

@shoffmeister
Copy link

Describe the bug

The vscode extension sometimes emits diagnostic entries into the "Problems" area. These entries are missing the source field - and this makes it difficult to determine that the reported problem originates from this extension here.

To Reproduce

In a Spring Boot project, create an application.yaml file with this content:

---
performance:
  max-internal-processing-concurrency: 10

Observe the rendering of the Problems entry created by this extension:

image

//exp: information on screen that flags this problem as a Spring Boot problem
//act: nothing suggests that this is a Spring Boot problem

Root cause is simply that, when emitting the diagnostic entry into the vscode host,

[{
	"resource": " ... /src/main/resources/application.yml",
	"owner": "_generated_diagnostic_collection_name_#5",
	"code": "YAML_UNKNOWN_PROPERTY",
	"severity": 4,
	"message": "Unknown property 'performance'",
	"startLineNumber": 2,
	"startColumn": 1,
	"endLineNumber": 2,
	"endColumn": 12
}]

this extension fails to emit the source field which vscode uses to flag the originator.

Please add unique identifying content into a source field

Sample

A link to a GitHub repository with a minimal, reproducible sample.

Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.

@BoykoAlex
Copy link
Contributor

I'm going to put extension id in the source field for starters.

@BoykoAlex
Copy link
Contributor

Fixed with cbdd118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants