remove WTP-based HTML tooling from Spring Tools 4 distribution

[4javier]

I cross-post this issue from WildWebDeveloper project, because on a vanilla Eclipse installation it doesn't show up.
eclipse-wildwebdeveloper/wildwebdeveloper#552
I tried to install latest snapshot as suggested, with no luck. (On plain Eclipse there's no need to update the plugin, it works even with release).

Every angular directive inside any template gets marked as undefined, but at the same time, its doc gets correctly shown on hover.

To quickly reproduce the issue, just import this basic project and try to validate app.component.html
https://github.com/4javier/angular-ivy-base

[martinlippert]

Can you please double check this with the latest STS 4.9.0 release? It also includes the latest Wild Web Developer components. In addition to that please make sure to open the file with the "Generic Text Editor", since this uses the Angular tooling of WWD.

Just opening the file with a double click uses the old HTML editor from WTP, which doesn't know much about Angular, I guess.

With regards to the update path:
Using the latest snapshot update site from WWD should work now, there was most likely a compatibility issue with the previous versions that we used that prevented the update in the past. We certainly don't restrict the included WWD version down to the specific one.

[4javier]

@martinlippert
I don't know why did you close the issue.
I'm on 4.9.0 and the problem is still present.
I always used Generic Text Editor and I set it up as associated editor for every web related filetype, otherwise it's like not using WWD at all.
The problem is due to the HTML Validator that STS is shipped with, and that's by default enabled to run on "Manual" and "Build" (don't know what "build" could mean talking about html files...)
Disabling it from Window→Preferences→Validation→HTML Syntax Validator solved the issue.
Right way would have been to add Angular elements, directive and attributes to its list, but doing it manually is a pain, and I'm not sure it's feasible for things like directives and bound DOM properties.

[martinlippert]

@4javier The solution here would be to finally get rid of the old WTP-based HTML tooling that sneaked into the STS4 distribution. We don't really include this on purpose, it makes its way into the distribution as a dependency to some other feature that we want to include.

So you are right, we should keep it open and see how we can get rid of the remaining old HTML tooling components. Would it be fine with you if we rename this issue accordingly?

[4javier]

Sure.
Feel free to rename it in the more meaningful way.
I think it's even good to put here the link to the generic WTP ticket:
#354
Later, I'll check if there's a way to disable HTML Synatx validator by default, and eventually link it to you.

[4javier]

It seems that this is the value that disable both manual both build html validator
/instance/org.eclipse.wst.validation/vals/org.eclipse.wst.html.core.HTMLValidator/global=FF01

[martinlippert]

I removed the m2e-wtp features for jaxrs and jsf, which removes more of the additional WTP tooling dependencies. Feel free to download a latest CI distribution build from here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html - and give it a try.

[4javier]

Perfect @martinlippert
Now HTML Syntax Validator is not listed at all inside Preference→Validation.
Even better than disabling it by default.
Thanks a lot.

[martinlippert]

@4javier Great to hear, thanks for letting us know.

[perry2of5]

Removing WTP seems to break xsd resolution in Wild Web Developer when behind a corporate firewall which denies the connection to download the xsd. See discussion here: eclipse-wildwebdeveloper/wildwebdeveloper#778

[perry2of5]

WildWebDeveloper recommended filing an issue with lemminx to resolve this. Since the developer is also a lemminx developer, I think this will fix the issue in the long run :)

In the short run, either download the xsd files you need manually and create a catolog or install WTP if you run into this issue.

lemminx issue: eclipse-lemminx/lemminx#1182