Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STS4 Does Not Start After Installing Papyrus Plugin #499

Closed
WoodenCode00 opened this issue Jul 2, 2020 · 20 comments
Closed

STS4 Does Not Start After Installing Papyrus Plugin #499

WoodenCode00 opened this issue Jul 2, 2020 · 20 comments
Milestone
4.8.0.RELEASE

Comments

@WoodenCode00
Copy link

Absolutely new installation of STS 4.7.0 does not start anymore after installing Payrus for UML plugin v. 4.8.0.202006100749. Attached is log file that was generated in STS workspace folder.
From the log we can see that the root cause exception is :

!ENTRY org.eclipse.osgi 4 0 2020-07-02 00:33:11.207
!MESSAGE Application error
!STACK 1
java.lang.NullPointerException
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1091)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1047)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:658)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:557)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:154)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:150)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:657)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:594)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1447)

!ENTRY org.eclipse.gmf.runtime.common.ui 4 0 2020-07-02 00:33:11.262
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Exception in org.eclipse.gmf.runtime.common.ui.internal.CommonUIPlugin.stop() of bundle org.eclipse.gmf.runtime.common.ui.
	at org.eclipse.osgi.internal.framework.BundleContextImpl.stop(BundleContextImpl.java:920)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.stopWorker0(EquinoxBundle.java:1029)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.stopWorker(EquinoxBundle.java:370)
	at org.eclipse.osgi.container.Module.doStop(Module.java:660)
	at org.eclipse.osgi.container.Module.stop(Module.java:521)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.decStartLevel(ModuleContainer.java:1886)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1761)
	at org.eclipse.osgi.container.SystemModule.stopWorker(SystemModule.java:275)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle$EquinoxSystemModule.stopWorker(EquinoxBundle.java:202)
	at org.eclipse.osgi.container.Module.doStop(Module.java:660)
	at org.eclipse.osgi.container.Module.stop(Module.java:521)
	at org.eclipse.osgi.container.SystemModule.stop(SystemModule.java:207)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle$EquinoxSystemModule$1.run(EquinoxBundle.java:220)
	at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
	at org.eclipse.gmf.runtime.common.ui.util.UIModificationValidator.dispose(UIModificationValidator.java:208)
	at org.eclipse.gmf.runtime.common.ui.internal.CommonUIPlugin.stop(CommonUIPlugin.java:84)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$4.run(BundleContextImpl.java:900)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$4.run(BundleContextImpl.java:1)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.stop(BundleContextImpl.java:892)
	... 13 more
Root exception:
java.lang.NullPointerException
	at org.eclipse.gmf.runtime.common.ui.util.UIModificationValidator.dispose(UIModificationValidator.java:208)
	at org.eclipse.gmf.runtime.common.ui.internal.CommonUIPlugin.stop(CommonUIPlugin.java:84)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$4.run(BundleContextImpl.java:900)
	at org.eclipse.osgi.internal.framework.BundleContextImpl$4.run(BundleContextImpl.java:1)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.stop(BundleContextImpl.java:892)
	at org.eclipse.osgi.internal.framework.EquinoxBundle.stopWorker0(EquinoxBundle.java:1029)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.stopWorker(EquinoxBundle.java:370)
	at org.eclipse.osgi.container.Module.doStop(Module.java:660)
	at org.eclipse.osgi.container.Module.stop(Module.java:521)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.decStartLevel(ModuleContainer.java:1886)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1761)
	at org.eclipse.osgi.container.SystemModule.stopWorker(SystemModule.java:275)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle$EquinoxSystemModule.stopWorker(EquinoxBundle.java:202)
	at org.eclipse.osgi.container.Module.doStop(Module.java:660)
	at org.eclipse.osgi.container.Module.stop(Module.java:521)
	at org.eclipse.osgi.container.SystemModule.stop(SystemModule.java:207)
	at org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle$EquinoxSystemModule$1.run(EquinoxBundle.java:220)
	at java.lang.Thread.run(Unknown Source)

sts4.log
@kdvolder
Copy link
Member

kdvolder commented Jul 2, 2020

I'm seeing a lot of package-use conflicts in the error log, this is most likely the cause of the problems. These problems tend to be the result of a particular combination of plugins being installed at the same time. Can you please provide precise details on what you install i.e. what distribution/package/download do you start from and exactly what extensions, do you install into it?

If you gives us precise set of steps we can try to reproduce the problem and investigate.

@WoodenCode00
Copy link
Author

WoodenCode00 commented Jul 2, 2020 •
edited
Loading

What I'm doing is:

  • install STS4 4.7.0.RELEASE
  • right after, Install Software / search for Papyrus for UML plugin (current version is v. 4.8.0.202006100749) and install it. Papyrus installation seems to be correctly completed, I did not see any error messages
  • restart STS - it did not start

This error always happens. So basically in my STS installation Papyrus for UML is the only plugin I installed. And this is a new laptop so there are no traces of previous STS versions.

@kdvolder
Copy link
Member

kdvolder commented Jul 2, 2020

Sorry, still not totally clear because there are number of different ways to 'install STS4 4.7.0.RELEASE'. Are you downloading a full distribution bundle of STS? Or are you installing it into an Eclipse instance via the Eclipse marketplace? If the latter, what version of Eclipse is being used as the 'base' for this installation?

@WoodenCode00
Copy link
Author

WoodenCode00 commented Jul 2, 2020 •
edited
Loading

I donwloaded a JAR from Spring site
https://download.springsource.com/release/STS4/4.7.0.RELEASE/dist/e4.16/spring-tool-suite-4-4.7.0.RELEASE-e4.16.0-win32.win32.x86_64.self-extracting.jar

I did not install Eclipse, and Eclipse were never installed earlier on this machine (Windows 10).

@kdvolder
Copy link
Member

kdvolder commented Jul 6, 2020 •
edited
Loading

Sorry to keep coming back to this but I have no idea which is the plugin you refer to as Papyrus for UML. I searched Eclipse marketplace as well as google. While there are good number of things that show up there's not a single one that is called 'Papyrus for UML'.

For example here's a search of Eclipse marketplace:

https://marketplace.eclipse.org/search/site/papyrus%2520for%2520uml

Is any of these the one that you installed?

@WoodenCode00
Copy link
Author

I installed it through the command menu Help / Install New Software...
This is a screenshot:
image

@WoodenCode00
Copy link
Author

If helps, it is Papyrus home page: https://www.eclipse.org/papyrus/download.html

@BoykoAlex
Copy link
Contributor

Papyrus has installed fine for me in my STS 4.7.0 on eclipse 4.16.

Try perhaps opening a brand new workspace.

Note that stack trace does not point to anything in STS but rather GMF which the dependency for Papyrus... Perhaps try asking GMF or Papyrus folks what might have gone wrong...

@martinlippert
Copy link
Member

I am able to reproduce this issue, starting with a fresh STS4 4.7.0 distribution on my macOS, switching that to run on a JDK8 (the Oracle JDK 1.8.0_251 in my case), and installing the Papyrus UML feature from the main Eclipse repo. After that, the IDE doesn't start. Instead it seems to do something in the background for a very long time (minutes), before it shows the dialog to select the workspace, and then fails with similar errors as you have in your.log file.

The reason seems to be a problematic package use conflict among several bundles. We need to investigate in more detail what exactly causes the dependency resolver to screw this up here.

The workaround that worked for me is to manually start the IDE from the command line with the -clean option. That causes the runtime to re-resolve all the dependencies and that computes a dependency graph that doesn't have the previous issues. Hope that workaround works for you @WoodenCode00, too. Can you try that?

@martinlippert
Copy link
Member

(btw, the JDK that you run the IDE on might make an important difference here, since the OSGi dependency resolving of the javax packages works differently on JDK8 than on JDK9 and above (due to the JDK module system).

@kdvolder
Copy link
Member

kdvolder commented Jul 8, 2020

Though the errors look a little different, it sounds similar in many ways to https://bugs.eclipse.org/bugs/show_bug.cgi?id=564475

I.m.o if -clean solves the issue this implies there isn't actually a problem with the particular combination of plugins and resolution contstraints they imply, but rather a issue with the resolver getting stuck somehow in a state where it incorrectly thinks those contstraints are 'unresolvable' when in fact they are solveable after all.

@martinlippert
Copy link
Member

@kdvolder That might be true, but nevertheless we should probably try to make it easier for the resolver and avoid the Require-Bundle dependency on org.eclipse.core.runtime. This causes issues again and again and also causes the resolution to behave differently when running on different JDKs. So not defining that dependency in such a way might help - independent of the way the resolver deals with dependencies when you install additional plugins (which is slightly different from running with the -clean option, maybe for a good reason).

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

I was also able to reproduce this.

  • take a STS 4.7.0 full distribution
  • install "papyrus for UML" as described from 'all available update sites'.

Strangely, when I select this broken installation as my 'target platform' and start it in a Eclipse runtime workbench it launches just fine.

That unfortunately makes it rather hard / impossible to trouble-shoot or test potential attempts at fixing this by means of changing STS bundle requirements.

What I wanted to try is: examine the error log messages and try to adjust some of our bundle requirement that seem to be involved with these errors... and then see if this makes the problem disapear.

But as the conflict seems more like an artefact of how equinox handles incremenal installations rather than an actual 'unsolvable' constraint in the bundles themselves, and is not reproducible in a runtime workbench it is going to be very time consuming to trial an error some things. The only way I can think of doing this would be to:

  • make some changes and commit them
  • wait for next snapshot full distribution build (this takes a few hours)
  • download it and try if the issue is fixed.

@kdvolder
Copy link
Member

kdvolder commented Jul 8, 2020

Filed a bug on bugzilla as to my mind, this seems like a bug in Eclipse Equinox: https://bugs.eclipse.org/bugs/show_bug.cgi?id=565066

I agree though with Martin that even if this is so, it's still a good idea to try and make our constraints 'easier' to solve and maybe avoid the issue that way.

@WoodenCode00
Copy link
Author

The workaround that worked for me is to manually start the IDE from the command line with the -clean option. That causes the runtime to re-resolve all the dependencies and that computes a dependency graph that doesn't have the previous issues. Hope that workaround works for you @WoodenCode00, too. Can you try that?

Thanks @martinlippert . I added -clean option to SpringToolSuite4.ini file from the STS4 root folder and started the IDE as usual, by clicking on exe file. Now IDE can start and Papyrus plugin works fine.

@WoodenCode00
Copy link
Author

Also, there is another plugin that makes STS4 fail to start after installing it - TypeScript :: CodeMix (https://marketplace.eclipse.org/content/typescript-codemix).
Again here, if STS is started with -clean option, it solves the issue.

@WoodenCode00
Copy link
Author

If it is important, I'm on Java 8.

@kdvolder
Copy link
Member

Looks like there's a fix forthcoming on https://bugs.eclipse.org/bugs/show_bug.cgi?id=565066

Also I did work on our dependencies as sugested by Martin and I think that also helped. So hopefully in next release of STS this will no longer be an issue. I'll keep this ticket open until I can verify the problem is really resolved.

@kdvolder
Copy link
Member

On the latest CI build I have no more package-use conflicts upon performing the same steps with Papyrus install. So I think that means the adjustments to bundle dependencies did avoid the resolver issue.

Unfortunately even after that STS still doesn't start up (without -clean) and crashes with a NPE that now looks identical to what's reported in eclipse bug https://bugs.eclipse.org/bugs/attachment.cgi?id=283355

@martinlippert martinlippert added this to the 4.7.1.RELEASE milestone Jul 27, 2020
@martinlippert
Copy link
Member

OK, I am closing this issue and mark it as fixed. Here is a quick summary:

  • the issue happens when running on JDK8 only
  • the workaround for this is to run the IDE with then -clean option once after the error appeared

The fix in the Eclipse platform works, but is part of the upcoming Eclipse 2020-09 release (late September), so nothing we can adopt for our upcoming Spring Tools 4.7.1 release. Spring Tools 4.8.0 will be based on Eclipse 2020-09 and will be GA in late September, but will also require JDK11 as a minimum environment to run the IDE with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0.RELEASE
Development

No branches or pull requests
5 participants
@martinlippert @kdvolder @BoykoAlex @WoodenCode00 @spring-projects-issues