Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async completions in 4.15 #402

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Jan 13, 2020

Marked the SpringBootJavaCompletionProposalComputer as requiresUIThread
= false so that the completions can be run asyncly.

This will make the new java async support to work even when STS4 tooling is installed.

Marked the SpringBootJavaCompletionProposalComputer as requiresUIThread
= false so that the completions can be run asyncly.
@BoykoAlex BoykoAlex merged commit a0732d1 into spring-projects:master Jan 14, 2020
@kdvolder
Copy link
Member

How do we know that this works?

@gayanper
Copy link
Contributor Author

https://bugs.eclipse.org/bugs/show_bug.cgi?id=531061

We need to test with 4.15 M1. I can test the nightly build when this change is available. When will it be available @BoykoAlex ?

@martinlippert
Copy link
Member

@gayanper You can get the latest CI builds from here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html (full distribution builds as well as p2 repo URLs)

@martinlippert martinlippert added this to the 4.5.1.RELEASE milestone Jan 15, 2020
@gayanper
Copy link
Contributor Author

I can still see this warning
image
From where does this completion comes from ?

@BoykoAlex
Copy link
Contributor

It comes from spring-ide project: https://github.com/spring-projects/spring-ide

@gayanper
Copy link
Contributor Author

Can we remove that from the installation without effecting much of sts4 functionality? Or should we fix it as well ?

@kdvolder
Copy link
Member

When I am asking "how do we know this works" it is not so much about whether that flag itself works. I'm questioning whether you can just make the affected completion providers run on non-ui thread without throwing 'invalid thread' exceptions and/or misbehaving in any other unexpected ways.

There is actually quite a lot of Eclipse api that just throws invaldid thread excpeption when callled from non-ui thread.

So yeah, testing thoroughly whether the changed completion providers still work is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants