Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse 4.10 install sts4 4.1.2,all source java class Ctrl+left mouse button will fail #205

Closed
MayBing opened this issue Feb 25, 2019 · 8 comments
Assignees
Milestone

Comments

@MayBing
Copy link

MayBing commented Feb 25, 2019

No description provided.

@martinlippert
Copy link
Member

Can you elaborate in more detail what happens and how to reproduce this issue? Would also be good to know whether this problems happens only if you install the STS4 pieces into Eclipse or even without that (using a plain Eclipse install).

@BoykoAlex
Copy link
Contributor

BoykoAlex commented Feb 25, 2019

I reproduced... yes, STS4 to blame it seems :-(

Open java.io.File and try Ctrl + mouse click on any Java type inside file

java.lang.NullPointerException
	at org.eclipse.lsp4e.operations.declaration.OpenDeclarationHyperlinkDetector.detectHyperlinks(OpenDeclarationHyperlinkDetector.java:79)
	at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:81)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:289)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:262)
	at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:457)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:216)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4319)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1512)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1535)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1520)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1324)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4143)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3760)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:636)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:595)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1501)

@BoykoAlex BoykoAlex self-assigned this Feb 25, 2019
@BoykoAlex
Copy link
Contributor

Should be fixed when this is resolved: https://bugs.eclipse.org/bugs/show_bug.cgi?id=544794

@MayBing
Copy link
Author

MayBing commented Feb 26, 2019

2019-02-26_9-30-56

Before installation, ctrl+left can be entered the source code. ctrl+left does not display open impelementation.

@martinlippert martinlippert changed the title eclipse 4.10 install sts4 4.1.2,all source java class Ctrl+left mouse button will failture eclipse 4.10 install sts4 4.1.2,all source java class Ctrl+left mouse button will fail Feb 27, 2019
@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Alex Boyko:)

I think it's fixed with https://bugs.eclipse.org/bugs/show_bug.cgi?id=544794 Mikael merged the quick fix for it rather quickly without requiring a test... Think the next STS4 eclipse nightly build would have the fix since we are targeting smapshot builds of lsp4e

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Alex Boyko:)

Should be in the nightly builds already...

@user20161119
Copy link

Waiting for 4.2.0

@BoykoAlex
Copy link
Contributor

Another option is try LSP4E project nightly build as the fix went in that project. Here is the nighly build update site: http://download.eclipse.org/lsp4e/snapshots/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants