Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Boot processes from IDE client #1190

Closed
BoykoAlex opened this issue Feb 12, 2024 · 2 comments
Closed

Running Boot processes from IDE client #1190

BoykoAlex opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: enhancement

Comments

@BoykoAlex
Copy link
Contributor

Currently to connect to running Spring Boot Apps the Boot LS process uses JVM internal APIs to get all running java processes and then user can select one of these processes.
This approach won't work with the Graal VM native image of the Boot LS. We can limit the list of java processes to those launched via the IDE client (VSCode/Eclipse)
(cc: @martinlippert )

@BoykoAlex BoykoAlex added this to the 4.22.0.RELEASE milestone Feb 12, 2024
@BoykoAlex BoykoAlex self-assigned this Feb 12, 2024
@martinlippert martinlippert added for: eclipse something that is specific for Eclipse theme: live-data for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Feb 13, 2024
@martinlippert
Copy link
Member

Yes, makes sense to me. We could include a preference that switches this behavior back to "show all JVM processes on the machine", in case the language server runs on a regular JVM (not a native image). But the default behavior should be to show the list of processes launched via the IDE client.

It would also make the list of processes a lot cleaner when they show up in the menu (quick pick or drop-down) to select a process, e.g. when changing log levels, connect to the process, etc.

@BoykoAlex
Copy link
Contributor Author

Fixed with eb3d46d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants