Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Modulith verifications broken #1127

Closed
odrotbohm opened this issue Oct 19, 2023 · 3 comments
Closed

Spring Modulith verifications broken #1127

odrotbohm opened this issue Oct 19, 2023 · 3 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode status: needs-investigation type: bug

Comments

@odrotbohm
Copy link
Member

If you import Spring RESTBucks into VSCode the Spring Modulith verification rejects code in OrderInitializer looking as follows:

Screenshot 2023-10-19 at 23 07 35

All types are marked with the message “Type not exposed by core module” despite the types not residing in the core module.

@BoykoAlex
Copy link
Contributor

BoykoAlex commented Oct 19, 2023

I have attempted not to resolve anything while reconciling but it looks like i just broke everything for the case Modulith. Hopefully, I have corrected most of the things with 58635fd

Currently, I only see one issue: org.springsource.restbucks.order.web.LocationAndDrinks is considered to be from order module... I suppose that the only case when LocationAndDrinks would belong to order module is if the package was org.springsource.restbucks.order.internal rather than org.springsource.restbucks.order.web. Is this correct? Thus internal is a special case where i can assume that parent package is the module, right?

What about org.springsource.restbucks.order.internal.a.b.c.d.e.f? Would this laso be considered to be under org.springsource.restbucks.order base package?

@BoykoAlex BoykoAlex self-assigned this Oct 20, 2023
@BoykoAlex BoykoAlex added this to the 4.20.1.RELEASE milestone Oct 20, 2023
@martinlippert martinlippert added status: needs-investigation for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Oct 20, 2023
@BoykoAlex
Copy link
Contributor

With additional fix of the error message: 68985b8 looks like this is fixed.

@odrotbohm
Copy link
Member Author

Thanks for the quick turnaround! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode status: needs-investigation type: bug
Projects
None yet
Development

No branches or pull requests

3 participants