Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimization] Boot properties completions slow to show up #1120

Closed
BoykoAlex opened this issue Oct 9, 2023 · 1 comment
Closed

[optimization] Boot properties completions slow to show up #1120

BoykoAlex opened this issue Oct 9, 2023 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: performance theme: property-editing-support type: enhancement

Comments

@BoykoAlex
Copy link
Contributor

Initial invocation of content assists for completion proposals may be very slow (~2 sec) for the initial invocation or invocation after the classpath change.

The issue is completion text edit fetches java type data from JDT LS for all property value types. Instead it'd be good to push the computation of part of the edit to the completion item resolve stage. Alternative could be making value type fetching part of the spring properties indexing process (might be a better solution if we switch to YAML LS implementation for Spring Properties YAML)

@BoykoAlex
Copy link
Contributor Author

Should be addressed with 1dfba38. Lazy edit computed during resolve stage is the solution in the commit: 1dfba38

@martinlippert martinlippert added theme: performance theme: property-editing-support for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Oct 9, 2023
@martinlippert martinlippert changed the title Boot properties completions slow to show up [optimization] Boot properties completions slow to show up Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: performance theme: property-editing-support type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants