Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support @ConditionalOnProperty in property navigation feature #1033

Closed
martinlippert opened this issue Apr 29, 2023 · 2 comments
Closed

support @ConditionalOnProperty in property navigation feature #1033

martinlippert opened this issue Apr 29, 2023 · 2 comments
Assignees
@BoykoAlex
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: property-editing-support type: enhancement
Milestone
4.18.1.RELEASE

Comments

@martinlippert
Copy link
Member

martinlippert commented Apr 29, 2023 •
edited by BoykoAlex
Loading

As a follow-up from #761, we should also support navigating to the property definition locations when using @ConditionalOnProperty, for example @ConditionalOnProperty("petclinic.s1.message")

Also consider navigating to property defined by prefix and name:
@ConditionalOnProperty(prefix = "notification", name = "service")
@martinlippert martinlippert added type: enhancement theme: property-editing-support for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode labels Apr 29, 2023
@martinlippert martinlippert added this to the Backlog milestone Apr 29, 2023
@BoykoAlex
Copy link
Contributor

@martinlippert shouldn't be a problem at all. I'd try to sneak this into 4.18.1 Monday night.

@BoykoAlex BoykoAlex modified the milestones: Backlog, 4.18.1.RELEASE May 1, 2023
@BoykoAlex
Copy link
Contributor

Fixed with 85103b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: property-editing-support type: enhancement
Projects
None yet
Milestone
4.18.1.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex