Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fetch metrics data right after connecting live data to an app #1003

Closed
martinlippert opened this issue Mar 13, 2023 · 2 comments
Closed
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: enhancement

Comments

@martinlippert
Copy link
Member

As mentioned in #1002 (comment), at the moment the live hover mechanics fetch the live data for certain metrics right after creating a connection to the running application - whether the metrics data is used or not.

We should change this behavior in a way that metrics data is only fetched when it is needed.

Side note: we need to double check the memory visualization in the VSCode Spring Dashboard implementation that heavily relies on the metrics data when changing this behavior.

@vudayani
Copy link
Collaborator

@BoykoAlex
As you mentioned in #1002 (comment), we can remove the refresh metrics calls from here.

On the vscode-spring-boot-dashboard extension, we can execute the "sts/livedata/refresh/metrics" command to query for the memory metrics before trying to fetch and display it in the memory view. (microsoft/vscode-spring-boot-dashboard@868e02e)

@BoykoAlex
Copy link
Contributor

Thank you @vudayani-vmw !
I have removed the metrics refresh from the location referenced above: ddacce5ca0d96fc8002c543965c11ec4f503d486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: live-data type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants