-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2ClientConfiguration discovers client_credentials OAuth2AccessTokenResponseClient #6572
Comments
@fritzdj Thanks for taking this on! To start off, please get familiar with the Contributing guidelines. After you setup your spring-security fork in your local dev environment, get familiar with Let me know whenever you have any questions. |
@fritzdj are you working on this issue? if not, i can provide a PR 😛 |
Go for it @clevertension. I should have time later this week if you don't get to it. |
👍, it's yours, go ahead and nice coding |
@jgrandja, can you please respond to my questions from https://gitter.im/spring-projects/spring-security?at=5c81cda88f294b134a0768d2 - I'm not sure which platforms works best for these types of questions. NOTE: I think I understand the second question now -> it's not really tied to the principle for client credentials calls after testing it out. I'm still questioning how to best handle refreshing access tokens - it seems like it should be a part of the handler to get an authorized client. Please let me know your thoughts. |
It's best to keep the questions/dialogue either in this issue or the submitted PR.
Thanks for catching this! This needs to be implemented in a separate PR so I've logged #6609 to track it. |
We should allow for a
@Bean
of typeOAuth2AccessTokenResponseClient<OAuth2ClientCredentialsGrantRequest>
to be discovered byOAuth2ClientConfiguration
. This would than be associated withOAuth2AuthorizedClientArgumentResolver.setClientCredentialsTokenResponseClient()
.Ultimately, this will allow the user to register a
DefaultClientCredentialsTokenResponseClient
@Bean
with a configuredRestOperations
and/orConverter<OAuth2ClientCredentialsGrantRequest, RequestEntity<?>>
.The text was updated successfully, but these errors were encountered: