Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT generates a raw type for a generic type with nested unresolved generics #33069

Closed
snicoll opened this issue Jun 19, 2024 · 1 comment
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jun 19, 2024

Initially reported by @odrotbohm on Spring Restbucks.

There is a check in code generator for ResolvableType:

if (resolvableType.hasGenerics() && !resolvableType.hasUnresolvableGenerics()) {

There have been several refinements in the core container and its type detection algorithm. I suspect that it's smarter at finding out about such unresolved generics in nested types. It unfortunately means we're taking the wrong decision now, writing the raw type instead of the type with it's top-level generic signature.

@snicoll snicoll added type: regression A bug that is also a regression theme: aot An issue related to Ahead-of-time processing labels Jun 19, 2024
@snicoll snicoll added this to the 6.2.0-M5 milestone Jun 19, 2024
@snicoll snicoll self-assigned this Jun 19, 2024
@snicoll
Copy link
Member Author

snicoll commented Jun 19, 2024

The check was introduced by #29454

@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label Jun 19, 2024
@snicoll snicoll changed the title AOT generates a raw type for a generic type with nested unresolved generics are AOT generates a raw type for a generic type with nested unresolved generics Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: regression A bug that is also a regression
Projects
None yet
Development

No branches or pull requests

2 participants