Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockHttpServletRequestBuilder should merge URI from the parent if necessary #33057

Closed
snicoll opened this issue Jun 17, 2024 · 0 comments
Closed

MockHttpServletRequestBuilder should merge URI from the parent if necessary #33057

snicoll opened this issue Jun 17, 2024 · 0 comments
Assignees
@snicoll
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.2.0-M5

Comments

@snicoll
Copy link
Member

snicoll commented Jun 17, 2024

As of #32913, Most of MockHttpServletRequestBuilder has moved to an abstract class that can only be built with an HttpMethod whereas previously both an HttpMethod and an URI were mandatory.

Moving URI as nullable means it can be inherited from a parent builder if it is not set yet. This isn't taken into account and can be a problem if you need to create a separate builder instance from one whose URI has been populated already.
@snicoll snicoll added in: test Issues in the test module type: enhancement A general enhancement labels Jun 17, 2024
@snicoll snicoll added this to the 6.2.0-M5 milestone Jun 17, 2024
@snicoll snicoll self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M5
Development

No branches or pull requests
1 participant
@snicoll