Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit parameter names in REST Clients section of reference docs #32335

Closed
ethan3011 opened this issue Feb 28, 2024 · 3 comments
Closed

Omit parameter names in REST Clients section of reference docs #32335

ethan3011 opened this issue Feb 28, 2024 · 3 comments
Assignees
@sbrannen
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Milestone
6.1.5

Comments

@ethan3011
Copy link

ethan3011 commented Feb 28, 2024 •
edited by sbrannen
Loading

Affects: 6.1.4 doc

I just saw HttpMethod method parameter in rest-clients.adoc.

I think it should be HttpMethod only, because other examples just use HttpMethod.

thanks

execute(String, **HttpMethod method**, RequestCallback, ResponseExtractor, Object...)
execute(String, **HttpMethod method**, RequestCallback, ResponseExtractor, Map)
execute(URI, **HttpMethod method**, RequestCallback, ResponseExtractor)
image
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 28, 2024
@ethan3011
Copy link
Author

compare with others
image

@sbrannen sbrannen self-assigned this Feb 28, 2024
@sbrannen sbrannen added the type: documentation A documentation task label Feb 28, 2024
@sbrannen sbrannen modified the milestones: 6.2.0-M1, 6.1.5 Feb 28, 2024
@sbrannen sbrannen changed the title rest-clients.adoc file has typo Omit parameter names in REST Clients section of reference docs Feb 28, 2024
@sbrannen
Copy link
Member

Hi @ethan3011,

Congratulations on submitting your first issue for the Spring Framework! 👍

I've addressed your concerns in 5830aac.

Cheers

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 28, 2024
@ethan3011
Copy link
Author

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
6.1.5
Development

No branches or pull requests
3 participants
@sbrannen @spring-projects-issues @ethan3011