Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringDecoder buffer leak related to maxInMemorySize limit #24339

Closed
rstoyanchev opened this issue Jan 13, 2020 · 0 comments
Closed

StringDecoder buffer leak related to maxInMemorySize limit #24339

rstoyanchev opened this issue Jan 13, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.2.3

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jan 13, 2020 •
edited
Loading

This was discovered while working on implementing the same type of limit for ServerSentEventsMessageReader which depends on StringDecoder to split the stream into lines (see #24312).

When a single input buffer contains multiple lines in which case slices for each line are retained, and if one of the earlier lines exceeds the limit, then subsequent lines are not released. This is due to a suspected issue with concatMapIterable not respecting doOnDiscard. I've added a reactor/reactor-core#1925 (comment) related to that.

The goal for this issue is to add a workaround.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Jan 13, 2020
@rstoyanchev rstoyanchev added this to the 5.2.3 milestone Jan 13, 2020
@rstoyanchev rstoyanchev self-assigned this Jan 13, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.2.3
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues