Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpEL ReflectivePropertyAccessor: ConversionService missing annotations on concrete implementations #23210

Closed
laoseth opened this issue Jun 28, 2019 · 0 comments
Closed

SpEL ReflectivePropertyAccessor: ConversionService missing annotations on concrete implementations #23210

laoseth opened this issue Jun 28, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Milestone
5.1.9

Comments

@laoseth
Copy link

laoseth commented Jun 28, 2019

The fix for #22242 is causing this.

Baiscally, the ReflectivePropertyAccessor is now looking for an interface for a method if it exists, and returning the interface method instead of the concrete one. In doing this, if the implementer has an annotation(in my case DateTimeFormat) it gets ignored, as the TypedValue returned is now based solely on the interface.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 28, 2019
@jhoeller jhoeller changed the title Conversion Service now missing annotations on Concrete Implementations SpEL ReflectivePropertyAccessor: ConversionService missing annotations on concrete implementations Jun 28, 2019
@jhoeller jhoeller self-assigned this Jun 28, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 28, 2019
@jhoeller jhoeller added this to the 5.1.9 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.1.9
Development

No branches or pull requests
3 participants
@jhoeller @spring-projects-issues @laoseth