Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReactivePageableExecutionUtils from Spring Data Commons #1946

Closed
czp3009 opened this issue Nov 21, 2024 · 1 comment
Closed

Use ReactivePageableExecutionUtils from Spring Data Commons #1946

czp3009 opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
type: enhancement A general enhancement

Comments

@czp3009
Copy link

czp3009 commented Nov 21, 2024

Reactive edition of PageableExecutionUtils is ReactivePageableExecutionUtils, it's a very useful utils class.

But what I want to know is why it's not public, when the original PageableExecutionUtils is marked as public?

This result to that I can use PageableExecutionUtils in my own code, but there is no way to use ReactivePageableExecutionUtils.

Is it possible to mark ReactivePageableExecutionUtils as public as well?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2024
@mp911de
Copy link
Member

mp911de commented Nov 21, 2024

We consider reactive pagination as unintended usage. Ideally, you do not require pagination to stream a lot of data because streaming the entire resultset is much more efficient and it avoids multiple server-roundtrips.

PageableExecutionUtils is part of Spring Data Commons while ReactivePageableExecutionUtils lives only in Spring Data Relational. I guess we could copy it into Commons and use it from there.

@mp911de mp911de self-assigned this Nov 21, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2024
@mp911de mp911de added this to the 3.5 M1 (2025.0.0) milestone Nov 21, 2024
@mp911de mp911de changed the title Why ReactivePageableExecutionUtils is not public Use ReactivePageableExecutionUtils from Spring Data Commons Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants