Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisClusterConfiguration.maxRedirects is not applied for Lettuce [DATAREDIS-949] #1523

Closed
spring-projects-issues opened this issue Mar 20, 2019 · 1 comment
Closed

RedisClusterConfiguration.maxRedirects is not applied for Lettuce [DATAREDIS-949] #1523

spring-projects-issues opened this issue Mar 20, 2019 · 1 comment
Assignees
@mp911de
Labels
in: core Issues in core support in: lettuce Lettuce driver type: task A general task
Milestone
2.2 M3 (Moore)

Comments

@spring-projects-issues
Copy link

Mark Paluch opened DATAREDIS-949 and commented

The configuration value from RedisClusterConfiguration.maxRedirects is not applied to Lettuce. Lettuce uses ClusterClientOptions to transport maxRedirects. We're creating already a ClientOptions object in LettuceClientConfigurationBuilder.

We need to copy over settings to ClusterClientOptions and apply maxRedirects

Affects: 2.0.13 (Kay SR13), 2.2 M2 (Moore), 2.1.5 (Lovelace SR5)

Reference URL: spring-projects/spring-boot#16271

Referenced from: pull request #417, and commits a0e3dca, 9ce10bb, 50818fb, ba53050, 2cb3e05, c632b69

Backported to: 2.1.6 (Lovelace SR6)
@spring-projects-issues
Copy link
Author

Mark Paluch commented

Should be backported to 2.1.x

@spring-projects-issues spring-projects-issues added in: lettuce Lettuce driver in: core Issues in core support type: task A general task labels Dec 30, 2020
@spring-projects-issues spring-projects-issues added this to the 2.2 M3 (Moore) milestone Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: core Issues in core support in: lettuce Lettuce driver type: task A general task
Projects
None yet
Milestone
2.2 M3 (Moore)
Development

No branches or pull requests
2 participants
@mp911de @spring-projects-issues