Add customization hook for reactive WebClient [DATAES-719]

[spring-projects-issues]

Takaaki Iida opened DATAES-719 and commented

When my app gets a large response from Elasticsearch by ReactiveElasticsearchClient, I will get below exception.

org.springframework.core.io.buffer.DataBufferLimitException: Exceeded limit on max bytes to buffer : 262144

This exception can be solved if I change a value of maxInMemorySize in WebClient but I can't customize it now. (see details by spring-projects/spring-framework#23961)

WebClient of ReactiveRestClients is instanced by below method and there are no extension point to customize it.

https://github.com/spring-projects/spring-data-elasticsearch/blob/3.2.3.RELEASE/src/main/java/org/springframework/data/elasticsearch/client/reactive/DefaultWebClientProvider.java#L137

 

Could you expose some extension point to customize it?

---

Affects: 4.0 M1 (Neumann), 3.2.3 (Moore SR3)

Referenced from: pull request #363, and commits 5bf073b, b731b47, 283b27d, f7a14c1

Backported to: 3.2.4 (Moore SR4)

[spring-projects-issues]

sothawo commented

The WebClient can be now configured like this (setting maxInMemorySize to unlimited in this example):

@Configuration
public class ReactiveRestClientConfig extends AbstractReactiveElasticsearchConfiguration {
    @Override
    public ReactiveElasticsearchClient reactiveElasticsearchClient() {
        final ClientConfiguration clientConfiguration = ClientConfiguration.builder() //
            .connectedTo("localhost:9200") //
            .withWebClientConfigurer(webClient -> {
                ExchangeStrategies exchangeStrategies = ExchangeStrategies.builder()
                    .codecs(configurer -> configurer.defaultCodecs()
                        .maxInMemorySize(-1))
                    .build();
                return webClient.mutate().exchangeStrategies(exchangeStrategies).build();
            })
            .build();
        return ReactiveRestClients.create(clientConfiguration);

    }
}

[spring-projects-issues]

Vity commented

in 4.0.4 there is max-in-memory-size property

spring:
 data:
  elasticsearch:
    client:
      reactive:
        max-in-memory-size: 10MB