Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated information from Javadoc for PageableHandlerMethodArgumentResolver[Support] #3188

Closed
wants to merge 1 commit into from

Conversation

sryze
Copy link
Contributor

@sryze sryze commented Oct 24, 2024

The information about default parameter prefix seems outdated. It looks like that portion of the comment was added back in the days when the paging parameters were named page.page and page.size by default and now they are just page and size by default. Also there is a missing whitespace between identifiers in HTML docs:
Screenshot 2024-10-25 at 00 09 54

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@sryze Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 24, 2024
@sryze
Copy link
Contributor Author

sryze commented Oct 24, 2024

Is there a way to sign the CLA without giving access to all account email addresses? I think it actually needs only one email.

@mp911de mp911de self-assigned this Oct 28, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 28, 2024
@mp911de mp911de added this to the 3.2.12 (2023.1.12) milestone Oct 29, 2024
mp911de pushed a commit that referenced this pull request Oct 29, 2024
mp911de added a commit that referenced this pull request Oct 29, 2024
Refine Javadoc and update ReactivePageableHandlerMethodArgumentResolver. Fix nullability annotations.

See #3188
mp911de pushed a commit that referenced this pull request Oct 29, 2024
mp911de added a commit that referenced this pull request Oct 29, 2024
Refine Javadoc and update ReactivePageableHandlerMethodArgumentResolver. Fix nullability annotations.

See #3188
@mp911de mp911de closed this in 7a5e4d7 Oct 29, 2024
mp911de added a commit that referenced this pull request Oct 29, 2024
Refine Javadoc and update ReactivePageableHandlerMethodArgumentResolver. Fix nullability annotations.

See #3188
@mp911de
Copy link
Member

mp911de commented Oct 29, 2024

CLA isn't required as this is a trivial fix.

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants