Dependency convergence error for nimbus-jose-jwt when depending on spring-boot-starter-oauth2-client #22996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomasKasene Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ThomasKasene Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Aug 25, 2020
wilkinsona
added a commit
that referenced
this pull request
Aug 25, 2020
|
@ThomasKasene Thanks very much for making your first contribution to Spring Boot. |
|
This breaks quite some tests unfortunately @wilkinsona . Could we revert this for the time being again? |
|
So it does. Sorry, @dreis2211. I probably shouldn't be pushing changes in my sleep-deprived state… |
|
We've all been there - no need to be sorry |
|
Spring Security 5.3.4 uses nimbus-jose-jwt 8.19 so let's align with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22947