Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliced tests doesn't reuse cached contexts when testing with Spock's spock.lang.* annotations. #8251

Closed
erling opened this issue Feb 9, 2017 · 1 comment
Closed

Sliced tests doesn't reuse cached contexts when testing with Spock's spock.lang.* annotations. #8251

erling opened this issue Feb 9, 2017 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@erling
Copy link

erling commented Feb 9, 2017 •
edited
Loading

Spock's spock.lang.* annotations to a specification makes each spec appear to be different:

@spock.lang.Ignore
static class FirstSpockAnnotatedTestClass {}

@spock.lang.Stepwise
static class SecondSpockAnnotatedTestClass {}

Only partially solved by issue 7524.

Added PR: https://github.com/spring-projects/spring-boot/pull/8252/files
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 9, 2017
@erling erling mentioned this issue Feb 9, 2017
Closed
@snicoll
Copy link
Member

snicoll commented Feb 10, 2017

Closing in favour of PR #8252 (@erling no need for a separate issue if you intend to submit a PR right the way).

@snicoll snicoll closed this as completed Feb 10, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 10, 2017
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snicoll @philwebb @erling @spring-projects-issues