Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSourceInitializer is not reusable #8068

Closed
snicoll opened this issue Jan 23, 2017 · 1 comment
Closed

DataSourceInitializer is not reusable #8068

snicoll opened this issue Jan 23, 2017 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@snicoll
Copy link
Member

snicoll commented Jan 23, 2017

In its current form, there is no easy way to initialize a secondary DataSource the same way Spring Boot does via auto-configuration. For one org.springframework.boot.autoconfigure.jdbc.DataSourceInitializer is package private (and has the same name as a feature in the core framework). It also has this DataSourceInitializedEvent that may (or may not) be relevant for a secondary DataSource.

The basic features take a DataSource and a DataSourceProperties. Perhaps we should have a public contract that can be reused and use an internal extension for our specific use cases?

This prevents to complete the documentation update (see #7652)

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Jan 23, 2017
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Feb 2, 2017
@snicoll
Copy link
Member Author

snicoll commented Feb 2, 2017

We've discussed that one and are not keen to act on it at the moment.

@snicoll snicoll closed this as completed Feb 2, 2017
@philwebb philwebb changed the title DataSourceInitializer is not reusable DataSourceInitializer is not reusable Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

1 participant