Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify default HTTP client redirect behavior and provide configuration option #42879

Closed
philwebb opened this issue Oct 25, 2024 · 5 comments
Closed

Unify default HTTP client redirect behavior and provide configuration option #42879

philwebb opened this issue Oct 25, 2024 · 5 comments
Assignees
@philwebb
Labels
theme: http-client-config Issues related to configuration of HTTP clients type: enhancement A general enhancement
Milestone
3.4.0-RC1

Comments

@philwebb
Copy link
Member

philwebb commented Oct 25, 2024 •
edited by wilkinsona
Loading

Switching to JdkClientHttpRequestFactory as our default has interesting implications when it comes to following redirects. By default, JdkClientHttpRequestFactory does not where as SimpleClientHttpRequestFactory does. We should consider carefully what our default should be and if we want to offer a quick way to change it.
@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 25, 2024
@philwebb philwebb changed the title Consider follow redirects for JdkClientHttpRequestFactory Allow redirect follow strategy to be defined and unify default behavior Oct 25, 2024
@philwebb philwebb self-assigned this Oct 25, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Oct 25, 2024
@philwebb philwebb modified the milestones: 3.4.0, 3.4.x Oct 25, 2024
@quaff
Copy link
Contributor

quaff commented Oct 25, 2024

#27360 is related.

@philwebb philwebb changed the title Allow redirect follow strategy to be defined and unify default behavior Unify default http client redirect behavior and provide configuration option Oct 25, 2024
@philwebb
Copy link
Member Author

Thanks @quaff. I wish we could configure redirects on a per call basis, but unfortunately that looks pretty tricky.

@philwebb philwebb added the theme: http-client-config Issues related to configuration of HTTP clients label Oct 25, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.4.0-RC1 Oct 25, 2024
@philwebb philwebb changed the title Unify default http client redirect behavior and provide configuration option Unify default HTTP client redirect behavior and provide configuration option Oct 25, 2024
@philwebb philwebb reopened this Oct 25, 2024
@philwebb
Copy link
Member Author

Reopening to check methods other than GET

@philwebb
Copy link
Member Author

philwebb commented Oct 25, 2024 •
edited
Loading

JDK Reactor Apache Jetty Simple
GET ✅ ✅ ✅ ✅ ✅
POST ✅ ✅ ✅ ✅ ⛔
PUT ✅ ✅ ✅ ✅ ⛔
PATCH ✅ ✅ ✅ ✅ ⛔
DELETE ✅ ✅ ✅ ✅ ⛔

@philwebb
Copy link
Member Author

Given that Simple is not likely to be used now, we'll leave things as they are. I'll add some more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
theme: http-client-config Issues related to configuration of HTTP clients type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-RC1
Development

No branches or pull requests
2 participants
@quaff @philwebb