Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

management.metrics.tags doesn't work in Spring Boot 3.2.1 version #38973

Closed
pavel-zeger opened this issue Jan 4, 2024 · 4 comments
Closed

management.metrics.tags doesn't work in Spring Boot 3.2.1 version #38973

pavel-zeger opened this issue Jan 4, 2024 · 4 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@pavel-zeger
Copy link

pavel-zeger commented Jan 4, 2024

Hello!

Following this closed issue I would like to report the bug with the management.metrics.tags used together with observation property management.observations.key-values: #38583.

Downgrading to the previous Spring Boot 3.1.6 version clearly shows the added metric tag when I check /actuator/prometheus endpoint. Upgrading to 3.2.1 eliminates any metrics tag (also default metrics like process_uptime_seconds and etc.) added via management.metrics.tags property.

I use both options: observations for controllers (with ObservedAspect) and custom tags for other metrics with management.metrics.tags property.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2024
@wilkinsona
Copy link
Member

If management.metrics.tags isn't working for you, I don't think it's related to the changes in #38583. That issue did not make any functional changes, it only removed the deprecation of the property. I also don't see the connection between default tags and default metrics such as process_uptime_seconds. The former should have no affect on whether or not the latter is present.

If you would like us to spend some more time investigating, please spend some time providing a complete yet minimal sample that reproduces the problem. You can share it with us by pushing it to a separate repository on GitHub or by zipping it up and attaching it to this issue.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 4, 2024
@pavel-zeger
Copy link
Author

I'll try to reproduce it outside my production service and publish it here. Thank you for the fast response.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 4, 2024
@bclozel bclozel added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jan 4, 2024
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jan 11, 2024
@pavel-zeger
Copy link
Author

I'm closing this issue due a lack of time to provide this information. I'll investigate it again and will open a new issue if needed with a relevant data. I apologize for waste of your time. Regards.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@bclozel bclozel added status: invalid An issue that we don't feel is valid and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

4 participants