Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider generics on ConfigurationPropertiesBinding beans #26034

Open
philwebb opened this issue Apr 13, 2021 · 3 comments
Open

Consider generics on ConfigurationPropertiesBinding beans #26034

philwebb opened this issue Apr 13, 2021 · 3 comments
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

Currently ConversionServiceDeducer registers converters and formatters using only the bean instance. This means that we don't consider generics on the method. See #24891 (comment) for one example of where this has tripped us up.

We might be able to get the bean definition and call getResolvableType() to obtain the method defined generics. We'd then probably need our own adapters (similar to the ones in GenericConversionService) to expose the method generics.

@wilkinsona
Copy link
Member

#22885 is a similar sort of problem.

@philwebb
Copy link
Member Author

Thanks @wilkinsona, I was searching for that one and couldn't find it.

@philwebb philwebb modified the milestones: General Backlog, 2.x Apr 13, 2021
@philwebb
Copy link
Member Author

#27410 is a similar issue for @ConditionalOnMissingBean

@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants