Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpringApplication can replace existing default property source #25408

Closed
philwebb opened this issue Feb 24, 2021 · 1 comment
Closed

SpringApplication can replace existing default property source #25408

philwebb opened this issue Feb 24, 2021 · 1 comment
Assignees
@mbhave
Labels
type: bug A general bug
Milestone
2.4.4

Comments

@philwebb
Copy link
Member

See spring-cloud/spring-cloud-commons#892 for background. The configurePropertySources method currently doesn't check if the environment already has a DefaultPropertySource. It looks like we might need to to merge rather than replace.
@philwebb philwebb added the type: bug A general bug label Feb 24, 2021
@philwebb philwebb added this to the 2.4.x milestone Feb 24, 2021
@philwebb philwebb mentioned this issue Feb 24, 2021
Closed
@slyoldfox
Copy link

Thanks for reraising this!

@mbhave mbhave self-assigned this Mar 2, 2021
@mbhave mbhave added the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 3, 2021
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 3, 2021
@mbhave mbhave mentioned this issue Mar 4, 2021
Closed
@mbhave mbhave closed this as completed in 181d0ee Mar 4, 2021
@mbhave mbhave modified the milestones: 2.4.x, 2.4.4 Mar 4, 2021
This was referenced Mar 18, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.4
Development

No branches or pull requests
3 participants
@philwebb @mbhave @slyoldfox