Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC-based implementation of the event publication registry #3

Closed
odrotbohm opened this issue Jul 6, 2022 · 1 comment
Closed

JDBC-based implementation of the event publication registry #3

odrotbohm opened this issue Jul 6, 2022 · 1 comment
Assignees
Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Milestone

Comments

@odrotbohm
Copy link
Member

No description provided.

@odrotbohm odrotbohm added in: event publication registry Event publication registry type: enhancement Major enhanvements, new features labels Jul 6, 2022
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
…epository types.

- Introduce Repository interface as a customization point
- Get rid of Registry interface by having one generic implementation
- Combine EventPublication and all its subclasses in one domain object
- Make Repository instead of Registry be dependent on EventSerializer

Signed-off-by: Dmitry Belyaev <[email protected]>
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
…epository types.

- Introduce Repository interface as a customization point
- Get rid of Registry interface by having one generic implementation
- Combine EventPublication and all its subclasses in one domain object
- Make Repository instead of Registry be dependent on EventSerializer

Signed-off-by: Dmitry Belyaev <[email protected]>
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
…epository types.

- Introduce Repository interface as a customization point
- Get rid of Registry interface by having one generic implementation
- Combine EventPublication and all its subclasses in one domain object
- Make Repository instead of Registry be dependent on EventSerializer

Signed-off-by: Dmitry Belyaev <[email protected]>
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
dmbelyaev pushed a commit that referenced this issue Jul 19, 2022
bkieling pushed a commit that referenced this issue Jul 21, 2022
…epository types.

- Introduce Repository interface as a customization point
- Get rid of Registry interface by having one generic implementation
- Combine EventPublication and all its subclasses in one domain object
- Make Repository instead of Registry be dependent on EventSerializer

Signed-off-by: Dmitry Belyaev <[email protected]>
bkieling pushed a commit that referenced this issue Jul 21, 2022
bkieling pushed a commit that referenced this issue Jul 21, 2022
…epository types.

- Introduce Repository interface as a customization point
- Get rid of Registry interface by having one generic implementation
- Combine EventPublication and all its subclasses in one domain object
- Make Repository instead of Registry be dependent on EventSerializer

Signed-off-by: Dmitry Belyaev <[email protected]>
bkieling pushed a commit that referenced this issue Jul 21, 2022
odrotbohm added a commit that referenced this issue Jul 22, 2022
A couple of renames in the exposed APIs. MapBasedEventPublicationRepository now uses a a TreeMap again instead of a List (closer to what the original EventPublicationRegistry did).

Cleanups in the JDBC event registry module. Polish pom.xml to minimize dependencies. Removed custom DatabaseType in favor of Boot's DatabaseDriver. Tweaked the auto-configuration of the JDBC module to not even expose a DatabaseSchemaInitializer in the first place to avoid having to wire the boolean flag into the latter.

Cleanups in test cases to avoid code duplication. Move to @jdbcTest to avoid having to depend on Spring Data JDBC.

Enable nullability checks, formatting, Javadoc, author tags, missing license headers.
@odrotbohm odrotbohm added this to the 0.1 M1 milestone Jul 22, 2022
@odrotbohm
Copy link
Member Author

That's polished and merged, thanks!

odrotbohm added a commit that referenced this issue Jul 28, 2022
odrotbohm added a commit that referenced this issue Jul 28, 2022
odrotbohm added a commit that referenced this issue Oct 21, 2022
…xecution order.

The tests previously asserted on no entries being found in the event publication tables. As other tests might have been run before, they could already contain some.
odrotbohm added a commit that referenced this issue Oct 21, 2022
…xecution order.

The tests previously asserted on no entries being found in the event publication tables. As other tests might have been run before, they could already contain some.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Projects
None yet
Development

No branches or pull requests

3 participants