-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Azure Spring 2.3.5 #534
Comments
Thanks for following up on the release!
@zhoufenqin I find changing the artifactId of a starter in a maintenance release a bit odd. What is the rationale for changing the name this way? This is not compliant with how third party starter should be named. |
Hi @snicoll , we are considering to change the naming convention of azure Spring starters to following convention: azure-spring-boot-starter-[-] Where is the corresponding azure service, is one feature of this azure service. Hope this is OK from Spring framework perspective? |
@snicoll , we are planning to change the artifact ids as: azure-active-directory-spring-boot-starter => azure-spring-boot-starter-active-directory The storage starter's current artifact id is spring-starter-azure-storage, and its id will be changed to azure-spring-boot-starter-storage. I think for now, we can just increase the azure-spring-boot-bom version to 2.3.5. After we change the artifact id (and increase the major version number), we will need your help to update and include the storage starter. |
That sounds good to me. A simple prefix and then the suffix used to qualify sounds like a good approach.
Isn't that going to break users though? You mentioned that the artifactId for storage was renamed there (something I still don't understand btw). Can you please bring back the artifactId as it was and release As I've mentioned, we can't promote something that doesn't comply with our naming conventions. |
Hi @snicoll, because of some of our internal rule, in next spring boot release version, all the azure spring boot starter library will be renamed, as Jialin said: The spring boot storage artifactId will be updated again in the next release version. |
any update? |
hi @snicoll, I think we can ignore the spring-starter-azure-storage starter for now. As 2.3.5 release is already out, on Spring initializer, we would like to make 2.3.5 the version for:
Today, no Spring initializer, the 2.3.3 version is still used. |
Hi,
The azure-spring-boot-bom of version 2.3.5 has been release to Maven: https://repo1.maven.org/maven2/com/microsoft/azure/azure-spring-boot-bom/2.3.5/
Please help to upgrade the version of bom to the latest, thanks.
Another problem:
The bom has this dependency before:
But now we update the artifactId. Current storage dependency is
The
com.microsoft.azure:spring-starter-azure-storage
supports Spring Boot 2.3.x, so could you support that providing different storage library when user choose the different Spring Boot version?Thanks
The text was updated successfully, but these errors were encountered: