Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Azure Spring 2.3.5 #534

Closed
zhoufenqin opened this issue Sep 16, 2020 · 7 comments
Closed

Upgrade to Azure Spring 2.3.5 #534

zhoufenqin opened this issue Sep 16, 2020 · 7 comments
Labels

Comments

@zhoufenqin
Copy link

Hi,
The azure-spring-boot-bom of version 2.3.5 has been release to Maven: https://repo1.maven.org/maven2/com/microsoft/azure/azure-spring-boot-bom/2.3.5/
Please help to upgrade the version of bom to the latest, thanks.

Another problem:
The bom has this dependency before:

name: Azure Storage
id: azure-storage
groupId: com.microsoft.azure
artifactId: azure-storage-spring-boot-starter

But now we update the artifactId. Current storage dependency is

name: Azure Storage
id: azure-storage
groupId: com.microsoft.azure
artifactId:spring-starter-azure-storage

The com.microsoft.azure:spring-starter-azure-storage supports Spring Boot 2.3.x, so could you support that providing different storage library when user choose the different Spring Boot version?

Thanks

@snicoll
Copy link
Contributor

snicoll commented Sep 16, 2020

Thanks for following up on the release!

spring-starter-azure-storage

@zhoufenqin I find changing the artifactId of a starter in a maintenance release a bit odd. What is the rationale for changing the name this way? This is not compliant with how third party starter should be named.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Sep 16, 2020
@jialindai
Copy link

Hi @snicoll , we are considering to change the naming convention of azure Spring starters to following convention:

azure-spring-boot-starter-[-]

Where is the corresponding azure service, is one feature of this azure service.

Hope this is OK from Spring framework perspective?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 17, 2020
@jialindai
Copy link

@snicoll , we are planning to change the artifact ids as:

azure-active-directory-spring-boot-starter => azure-spring-boot-starter-active-directory
azure-keyvault-secrets-spring-boot-starter => azure-spring-boot-starter-keyvault-secrets

The storage starter's current artifact id is spring-starter-azure-storage, and its id will be changed to azure-spring-boot-starter-storage.

I think for now, we can just increase the azure-spring-boot-bom version to 2.3.5.

After we change the artifact id (and increase the major version number), we will need your help to update and include the storage starter.

@snicoll
Copy link
Contributor

snicoll commented Sep 18, 2020

azure-spring-boot-starter-[-]

That sounds good to me. A simple prefix and then the suffix used to qualify sounds like a good approach.

I think for now, we can just increase the azure-spring-boot-bom version to 2.3.5.

Isn't that going to break users though? You mentioned that the artifactId for storage was renamed there (something I still don't understand btw). Can you please bring back the artifactId as it was and release 2.3.6? I know that 2.3.x is restricted to Spring Boot 2.3.x and that storage is disabled for 2.3.x but the wrong naming convention apply nonetheless.

As I've mentioned, we can't promote something that doesn't comply with our naming conventions.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Sep 18, 2020
@zhoufenqin
Copy link
Author

Hi @snicoll, because of some of our internal rule, in next spring boot release version, all the azure spring boot starter library will be renamed, as Jialin said:
azure-active-directory-spring-boot-starter => azure-spring-boot-starter-active-directory
azure-keyvault-secrets-spring-boot-starter => azure-spring-boot-starter-keyvault-secrets

The spring boot storage artifactId will be updated again in the next release version.
Because we have already released the azure spring boot starter 2.3.5 version, in Spring Initializer, can we just increase the azure-spring-boot-bom version to 2.3.5, except azure spring boot storage library (Keep it as disable as it is now)?
Thanks

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 19, 2020
@zhoufenqin
Copy link
Author

any update?

@jialindai
Copy link

hi @snicoll, I think we can ignore the spring-starter-azure-storage starter for now.

As 2.3.5 release is already out, on Spring initializer, we would like to make 2.3.5 the version for:

  • azure-active-directory-spring-boot-starter
  • azure-keyvault-secrets-spring-boot-starter
  • azure-spring-boot-starter

Today, no Spring initializer, the 2.3.3 version is still used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants