Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProjectRequest input validation to ProjectDescriptionCustomizer #1045

Closed
snicoll opened this issue Dec 27, 2019 · 0 comments
Closed

Move ProjectRequest input validation to ProjectDescriptionCustomizer #1045

snicoll opened this issue Dec 27, 2019 · 0 comments
Assignees
Milestone

Comments

@snicoll
Copy link
Contributor

snicoll commented Dec 27, 2019

Currently, DefaultProjectRequestToDescriptionConverter does the conversion from ProjectRequest to ProjectDescription and clean up invalid values or provide defaults in case of missing entries.

#1023 offers a way to track those changes but that won't track anything that is changed upfront. We should move all that cleaning logic to a proper ProjectDescriptionCustomizer so that we're able to see the value was changed.

Note that a side effect of that is that a bunch of properties will be flagged as changed if no original value was provided. This sounds like an added bonus to me as we'll be able to track if the user has provided no value vs. an invalid value we had to clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant